chore: pin node version in engines field#662
Open
archcorsair wants to merge 1 commit intomassCodeIO:masterfrom
Open
chore: pin node version in engines field#662archcorsair wants to merge 1 commit intomassCodeIO:masterfrom
archcorsair wants to merge 1 commit intomassCodeIO:masterfrom
Conversation
Adds a Node.js version constraint to `package.json` via the `engines` field matching the existing `volta` configuration. This ensures developers using environment managers other than Volta (such as `fnm` or `pnpm`) are warned when using an incompatible Node version. This helps prevent native module compilation errors, specifically with `better-sqlite3`, caused by ABI mismatches between the host Node environment and the Electron runtime.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a Node.js version constraint to
package.jsonvia theenginesfield matching the existingvoltaconfiguration.This ensures developers using environment managers other than Volta (such as
fnm,nvm, orn) are warned when using an incompatible Node version. This helps prevent native module compilation errors, specifically withbetter-sqlite3, caused by ABI mismatches between the host Node environment and the Electron runtime.What kind of change does this PR introduce?
Validations