Silence warning by using 'numberWithUnsignedInt:' to match NSUInteger return type of -[NSArray count].#5
Open
larrylegend wants to merge 3 commits intomarcammann:masterfrom
Open
Silence warning by using 'numberWithUnsignedInt:' to match NSUInteger return type of -[NSArray count].#5larrylegend wants to merge 3 commits intomarcammann:masterfrom
larrylegend wants to merge 3 commits intomarcammann:masterfrom
Conversation
… return type of -[NSArray count].
…erWithUnsignedInt:).
Author
|
Haha...goofed up on the first commit, you can just take the second one :) |
…an NSString containing the 6-character string "<null>".
Owner
|
Hey Larry! Sorry, I just saw this pull request. I commented on you 2nd commit to clear up the indents, but looks good otherwise. I'm slightly concerned that switching from signed to unsigned might break something somewhere for someone, but it's a countMapper after all, which really shouldn't ever be negative. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thanks for the excellent library! cc @AntonTheDev