fix: Add Defensive Code when Building URL Signatures#656
Merged
BrandonStalnaker merged 1 commit intomainfrom Mar 11, 2026
Merged
Conversation
📦 SDK Size Impact ReportMeasures how much the SDK adds to an app's size (with-SDK minus without-SDK).
➡️ SDK size impact change is minimal. Raw measurementsTarget branch (main): {"baseline_app_size_kb":84,"baseline_executable_size_bytes":75464,"with_sdk_app_size_kb":1944,"with_sdk_executable_size_bytes":76360,"sdk_impact_kb":1860,"sdk_executable_impact_bytes":896,"xcframework_size_kb":9716}This PR: {"baseline_app_size_kb":84,"baseline_executable_size_bytes":75464,"with_sdk_app_size_kb":1944,"with_sdk_executable_size_bytes":76360,"sdk_impact_kb":1860,"sdk_executable_impact_bytes":896,"xcframework_size_kb":9716} |
denischilik
reviewed
Mar 9, 2026
Contributor
denischilik
left a comment
There was a problem hiding this comment.
Discussed in person, looks like we can make secret and api key atomic to remove thread race issue. It will also be good to pass apiKey and secret to builder constructor, to remove additional dependency from MParticle.shared instance
Collaborator
Author
|
The issues Denis identified were from an older version of the SDK from before James' changes here. The client hasn't confirmed the sdk version being used in relation to this stack trace so its possible that change fixed it. That's part of why this commit is entirely defensive and perhaps overly cautious. |
jamesnrokt
approved these changes
Mar 9, 2026
nickolas-dimitrakas
approved these changes
Mar 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Background
What Has Changed
Checklist
Additional Notes
Reference Issue (For employees only. Ignore if you are an outside contributor)