DM-54081: Add a metric to measure the gradient of the median magnitude offset #461
+206
−12
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sr525
force-pushed
the
tickets/DM-54081
branch
from
ed90b71 to
1e63733
Compare
fred3m
approved these changes
Feb 9, 2026
Contributor
fred3m
left a comment
fred3m
left a comment
There was a problem hiding this comment.
LGTM. A minor naming request and fix the yaml lint errors.
| return scalarA / scalarB | ||
|
|
||
|
|
||
| class MedGradientAction(ScalarAction): |
Contributor
There was a problem hiding this comment.
Maybe make this MedianGraidentAction, consistent with MedianHistAction?
sr525
force-pushed
the
tickets/DM-54081
branch
4 times, most recently
from
a8e0847 to
0e28dff
Compare
sr525
force-pushed
the
tickets/DM-54081
branch
from
0e28dff to
d5d698f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.