DM-53414: Create analysis_tools plot of DiaObjects with few detections #459
Conversation
mrawls
force-pushed
the
tickets/DM-53414
branch
5 times, most recently
from
b28c213 to
db7e242
Compare
Scatter plot alpha, edgecolor, and point size are now configurable.
mrawls
force-pushed
the
tickets/DM-53414
branch
from
db7e242 to
6a02871
Compare
jrmullaney
left a comment
jrmullaney
left a comment
There was a problem hiding this comment.
Just some suggestions. Nothing major.
| bandText += band + ", " | ||
| bandsText = f", Bands: {bandText[:-2]}" | ||
| infoText = f"\n{run}{datasetsUsed}{tableType}{dataIdText}{bandsText}" | ||
| if (photocalibDataset != "None") or (astroDataset != "None"): |
There was a problem hiding this comment.
photocalibDataset and astroDataset are hard-coded to always be "None" and "None"! Clearly this was added as some kind of to-do that was never...done. I think it needs a ticket making to either implement or get-rid.
But let's not hold this merge up for that.
| ) | ||
|
|
||
| doBinning = Field[bool]( | ||
| doc="Use nPointBinThresh to implement binning.", |
There was a problem hiding this comment.
| doc="Use nPointBinThresh to implement binning.", | |
| doc="Spatially bin the data? Extreme outliers can be shown using `showExtremeOutliers`.", |
| nPointBinThresh=nPointBinThresh, | ||
| isSorted=True, | ||
| showExtremeOutliers=showExtremeOutliers, | ||
| scatPtSize=self.scatPtSize, |
There was a problem hiding this comment.
| scatPtSize=self.scatPtSize, | |
| scatPtSize=self.markerSize, |
| default=1.0, | ||
| ) | ||
|
|
||
| scatPtSize = Field[float]( |
There was a problem hiding this comment.
| scatPtSize = Field[float]( | |
| markerSize = Field[float]( |
There was a problem hiding this comment.
I know it's down as scatPtSize in plotProjectionWithBinning, but that's an awful name and I want to change it to markerSize throughout. I'll do that on a different ticket, though.
| @@ -0,0 +1,54 @@ | |||
| # This file is part of analysis_tools. | |||
There was a problem hiding this comment.
I don't think you need to make a new task. You could probably re-factor ObjectTableTractAnalysis, which also reads-in a tract-level data product. You'd just specify the different inputName in the pipeline task.
I've written a GenericTableAnalysis task for this kind of thing, but I've just not got round to merging it.
But, for now, if you want to keep this, then that's fine.
I think it's time that analysis_tools could benefit from a bit of an audit anyway.
2 participants
Plus a few improvements to SkyPlot that maintain current default behavior.