fix(git): expand tilde in SSH identity file paths#1049
fix(git): expand tilde in SSH identity file paths#1049Olshansk wants to merge 4 commits intoloderunner:mainfrom
Conversation
SSH identity file paths from ~/.ssh/config contain literal ~ which was not expanded to the home directory, causing "no valid authentication method" errors. Uses go-homedir (already a dependency) to expand paths before passing to go-git's SSH auth. Also adds a contributing guide with build/test/verify instructions. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
|
@loderunner Small fix I needed on As an aside - do you plan to depricate this in favor of other projects you're working with? I personally use |
loderunner
left a comment
There was a problem hiding this comment.
This seems like a good addition, and simple implementation too. 👍
Love the cookbook for hackers, too. Just a small docs nit to pick. Fix it and we're good to go.
|
@Olshansk thanks for the PR and the continued interest in scrt! I love that you're still using this. You're right, I should probably deprecate this, I haven't been keeping it up to date. If you're using this as a personal vault, though, you might want to take a look at my other project apiki. Has some similarities, but it's meant for personal usage and for environment variables. I'll try to get your PR merged, and I'd be happy to consider any further contributions. |
|
I fixed CI on |
|
@loderunner Appreciate the quick response.
Yea, I saw that you've been spending some time there and will check it out.
Synched to HEAD/
I also use the 1password CLI, but love the simplicity of Will keep you posted (if time permits), but might add 1password as a storage option in addition to local/git/s3. |
|
Alright, passes CI. Just address the comment in the contributing guide and I'll merge it. |
Co-authored-by: Charles Francoise <charles.francoise@gmail.com>
tl;dr SSH git storage now works on machines where
~/.ssh/configreturns identity paths with literal~.Summary
~) in identity file paths is now expanded to the home directory, fixing "no valid authentication method" errorsdocs/guide/contributing.mdwith copy-paste instructions for building, testing, and verifying changes locallyTable Diff
~/.ssh/id_ed25519passed to go-git (fails)/Users/<user>/.ssh/id_ed25519viago-homedirgo-homedirusagelocal.goonlygit.gofor SSH key pathsdocs/guide/contributing.md