Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
uses knope and it's accompanying bot (this is a github app that needs to be installed on the repo) for release management
Also makes the release workflows less stateful and allows manual triggering of the release workflows with a dry-run option (thanks to @ladvoc for that initial idea!)
One big difference is that knope only automates
It doesn't do any release publishing to the package repositories itself. So we stay in full control of that step (pushing releases to cargo/npm) so there are less surprises in how/what the tool itself supports in this step.
For the FFI release: after merging the release preview PR the github release will be marked as draft automatically by knope until it gets edited after the artifacts have been uploaded successfully
note: tag formatting changes slightly with this change from e.g.
rust-sdks/livekit-ffi@0.12.48tolivekit-ffi/v0.12.48