Skip to content

Rename test for circuit status failure to clarify expected behavior#1383

Merged
liudger merged 1 commit intomainfrom
small-fix
Mar 2, 2026
Merged

Rename test for circuit status failure to clarify expected behavior#1383
liudger merged 1 commit intomainfrom
small-fix

Conversation

@liudger
Copy link
Owner

@liudger liudger commented Mar 2, 2026

This pull request updates a test in tests/test_circuit.py to clarify and correct the behavior when a circuit status request fails. The test now ensures that a circuit is excluded (fail-safe) if the status request fails, rather than being detected.

Test behavior correction:

  • Renamed the test from test_get_available_circuits_status_failure_still_detects to test_get_available_circuits_status_failure_excludes_circuit and updated the docstring to reflect that a circuit should be excluded if the status request fails, aligning with fail-safe logic.

Copilot AI review requested due to automatic review settings March 2, 2026 13:11
@liudger liudger added documentation Solely about the documentation of the project. bugfix Inconsistencies or issues which will cause a problem for users or implementers. labels Mar 2, 2026
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR clarifies the intent of an existing circuit-detection test by renaming it and updating its docstring to match the library’s fail-safe behavior when a circuit status probe fails.

Changes:

  • Renamed the test to reflect that circuits are excluded when the status request fails.
  • Updated the test docstring to describe the fail-safe behavior more accurately.

@sonarqubecloud
Copy link

sonarqubecloud bot commented Mar 2, 2026

@codecov
Copy link

codecov bot commented Mar 2, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 99.89%. Comparing base (96a6f37) to head (978c439).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1383   +/-   ##
=======================================
  Coverage   99.89%   99.89%           
=======================================
  Files           6        6           
  Lines         997      997           
  Branches      139      139           
=======================================
  Hits          996      996           
  Partials        1        1           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@liudger liudger merged commit 920a7c8 into main Mar 2, 2026
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bugfix Inconsistencies or issues which will cause a problem for users or implementers. documentation Solely about the documentation of the project.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants