Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR clarifies the intent of an existing circuit-detection test by renaming it and updating its docstring to match the library’s fail-safe behavior when a circuit status probe fails.
Changes:
- Renamed the test to reflect that circuits are excluded when the status request fails.
- Updated the test docstring to describe the fail-safe behavior more accurately.
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1383 +/- ##
=======================================
Coverage 99.89% 99.89%
=======================================
Files 6 6
Lines 997 997
Branches 139 139
=======================================
Hits 996 996
Partials 1 1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



This pull request updates a test in
tests/test_circuit.pyto clarify and correct the behavior when a circuit status request fails. The test now ensures that a circuit is excluded (fail-safe) if the status request fails, rather than being detected.Test behavior correction:
test_get_available_circuits_status_failure_still_detectstotest_get_available_circuits_status_failure_excludes_circuitand updated the docstring to reflect that a circuit should be excluded if the status request fails, aligning with fail-safe logic.