Show dialog window instead of notification after uploading. #123
+32
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ve error handling.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue: linuxmint/cinnamon#13437
Apparently some users (including myself!) don't have notifications enabled so there is no discernible result that happens when upload button is pressed in mintreport.
This PR replaces the notification with a dialog window. It also improves the error handling.
Before
Happy Case
Notification sent to user after upload.
Users with notifications disabled would see nothing.
Sad case
Notification sent to user with the happy case message and an empty link, even though the pastebin script errored out. This is due to incomplete error handling.
Users with notifications disabled would see nothing.
After
Happy case
Dialog info window with happy case message
Unhappy case
Dialog error window with unhappy case message. Error from pastebin script is shown due to improved error handling.