generated from linux-system-roles/template
-
Notifications
You must be signed in to change notification settings - Fork 13
ci: skip most CI checks if title contains citest skip [citest_skip] #186
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reviewer's guide (collapsed on small PRs)Reviewer's GuideAdds a conditional to most GitHub Actions CI jobs so they are skipped when a pull request title contains the marker "[citest_skip]", reducing unnecessary CI runs for documentation or CI-only changes. Sequence diagram for conditional CI job execution based on PR titlesequenceDiagram
actor Developer
participant GitHub
participant GitHubActions
participant ansible_lint_job as ansible_lint
participant codespell_job as codespell
participant markdownlint_job as markdownlint
Developer->>GitHub: Open or update pull_request
GitHub-->>GitHubActions: pull_request event
GitHubActions->>GitHubActions: Read github.event.pull_request.title
alt title contains [citest_skip]
GitHubActions-->>ansible_lint_job: Do not start job (if condition false)
GitHubActions-->>codespell_job: Do not start job (if condition false)
GitHubActions-->>markdownlint_job: Do not start job (if condition false)
else title does not contain [citest_skip]
GitHubActions->>ansible_lint_job: Run ansible_lint job
GitHubActions->>codespell_job: Run codespell job
GitHubActions->>markdownlint_job: Run markdownlint job
end
Flow diagram for GitHub Actions CI skipping logic based on PR titleflowchart TD
A["pull_request event received"] --> B["Read github.event.pull_request.title"]
B --> C{"Title contains [citest_skip]?"}
C -- Yes --> D["Set job condition to false<br/>ansible_lint, ansible_managed_var_comment,<br/>codeql analyze, codespell, markdownlint, woke<br/>jobs are skipped"]
C -- No --> E["Job condition true<br/>Run ansible_lint job"]
C -- No --> F["Run ansible_managed_var_comment job"]
C -- No --> G["Run codeql analyze job"]
C -- No --> H["Run codespell job"]
C -- No --> I["Run markdownlint job"]
C -- No --> J["Run woke job"]
D --> K["CI completes with selected jobs skipped"]
E --> K
F --> K
G --> K
H --> K
I --> K
J --> K
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When we submit a PR for a CI update or docs, we do not want to start CI checking for ansible-lint, qemu, etc. When we are doing CI updates to 30 or more roles, this fires off a lot of unnecessary tests, which sometimes causes the linux-system-roles org in github to be throttled. When submitting a PR that can skip ci, use "[citest_skip]" in the PR title. Signed-off-by: Rich Megginson <rmeggins@redhat.com>
When we submit a PR for a CI update or docs, we do not want to start CI checking for ansible-lint, qemu, etc. When we are doing CI updates to 30 or more roles, this fires off a lot of unnecessary tests, which sometimes causes the linux-system-roles org in github to be throttled. When submitting a PR that can skip ci, use "[citest_skip]" in the PR title. Signed-off-by: Rich Megginson <rmeggins@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When we submit a PR for a CI update or docs, we do not want to start CI checking
for ansible-lint, qemu, etc. When we are doing CI updates to 30 or more
roles, this fires off a lot of unnecessary tests, which sometimes causes the
linux-system-roles org in github to be throttled.
When submitting a PR that can skip ci, use "[citest_skip]" in the PR title.