ci: use ANSIBLE_INJECT_FACT_VARS=false by default for testing

[richm]

Ansible 2.20 has deprecated the use of Ansible facts as variables. For
example, ansible_distribution is now deprecated in favor of
ansible_facts["distribution"]. This is due to making the default
setting INJECT_FACTS_AS_VARS=false. For now, this will create WARNING
messages, but in Ansible 2.24 it will be an error.

In order to ensure that commits and PRs conform to this, use
ANSIBLE_INJECT_FACT_VARS=false by default in our CI testing.

See https://docs.ansible.com/projects/ansible/latest/porting_guides/porting_guide_core_2.20.html#inject-facts-as-vars

Signed-off-by: Rich Megginson rmeggins@redhat.com

Summary by Sourcery

Configure CI to run Ansible with facts not injected as variables and adjust test vars accordingly.

CI:

• Set ANSIBLE_INJECT_FACT_VARS=false in qemu-kvm integration tests workflow to align with upcoming Ansible defaults.
• Propagate an SR_ANSIBLE_INJECT_FACT_VARS=false variable through the TFT GitHub Actions workflow for Terraform-based tests.

Tests:

• Update Red Hat distribution detection test variables to rely on the ansible_distribution fact name expected under the new facts-as-vars configuration.

[sourcery-ai]

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

Configures CI to run Ansible with ANSIBLE_INJECT_FACT_VARS disabled by default and adjusts test variables and TFT workflow wiring to be compatible with this behavior.

Flow diagram for SR_ANSIBLE_INJECT_FACT_VARS to Ansible behavior

flowchart TD
    A[GitHubActions tft workflow sets SR_ANSIBLE_INJECT_FACT_VARS=false] --> B[Terraform TFT receives SR_ANSIBLE_INJECT_FACT_VARS]
    B --> C[Terraform passes environment to Ansible test runs]
    C --> D[Ansible runs with ANSIBLE_INJECT_FACT_VARS=false]
    D --> E[Facts only available under ansible_facts map]
    E --> F[tests vars rh_distros_vars and playbooks must use ansible_facts keys]

Loading

File-Level Changes

Change	Details	Files
Align test variables with Ansible fact usage under CI settings that disable injecting facts as vars.	Update Red Hat distro detection variable to reference ansible_distribution instead of ansible_facts['distribution'] for CI runs where fact vars injection is disabled. Update Red Hat-or-Fedora distro detection variable to reference ansible_distribution instead of ansible_facts['distribution'].	tests/vars/rh_distros_vars.yml
Ensure all CI and TFT-driven Ansible executions run with ANSIBLE_INJECT_FACT_VARS disabled by default.	Set ANSIBLE_INJECT_FACT_VARS="false" in the qemu-kvm GitHub Actions workflow environment so tox/Ansible tests run with fact vars injection disabled. Propagate SR_ANSIBLE_INJECT_FACT_VARS=false into the TFT job variables so the external test framework invokes Ansible with fact vars injection disabled.	.github/workflows/qemu-kvm-integration-tests.yml .github/workflows/tft.yml

---

Tips and commands

Interacting with Sourcery

• Trigger a new review: Comment @sourcery-ai review on the pull request.
• Continue discussions: Reply directly to Sourcery's review comments.
• Generate a GitHub issue from a review comment: Ask Sourcery to create an
  issue from a review comment by replying to it. You can also reply to a
  review comment with @sourcery-ai issue to create an issue from it.
• Generate a pull request title: Write @sourcery-ai anywhere in the pull
  request title to generate a title at any time. You can also comment
  @sourcery-ai title on the pull request to (re-)generate the title at any time.
• Generate a pull request summary: Write @sourcery-ai summary anywhere in
  the pull request body to generate a PR summary at any time exactly where you
  want it. You can also comment @sourcery-ai summary on the pull request to
  (re-)generate the summary at any time.
• Generate reviewer's guide: Comment @sourcery-ai guide on the pull
  request to (re-)generate the reviewer's guide at any time.
• Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
  pull request to resolve all Sourcery comments. Useful if you've already
  addressed all the comments and don't want to see them anymore.
• Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
  request to dismiss all existing Sourcery reviews. Especially useful if you
  want to start fresh with a new review - don't forget to comment
  @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

• Enable or disable review features such as the Sourcery-generated pull request
  summary, the reviewer's guide, and others.
• Change the review language.
• Add, remove or edit custom review instructions.
• Adjust other review settings.

Getting Help

• Contact our support team for questions or feedback.
• Visit our documentation for detailed guides and information.
• Keep in touch with the Sourcery team by following us on X/Twitter, LinkedIn or GitHub.

[sourcery-ai]

Hey - I've left some high level feedback:

• The change in tests/vars/rh_distros_vars.yml goes in the opposite direction of the description/Ansible 2.20 guidance: you’re replacing ansible_facts['distribution'] with ansible_distribution, but with ANSIBLE_INJECT_FACT_VARS=false set in CI, you should be moving to ansible_facts['distribution'] everywhere instead of using the injected variable.
• Now that ANSIBLE_INJECT_FACT_VARS/SR_ANSIBLE_INJECT_FACT_VARS is being set in the workflows, consider centralizing or reusing this configuration (e.g., via a shared action or script) so the default doesn’t silently diverge between different CI jobs in the future.

Prompt for AI Agents

Please address the comments from this code review:

## Overall Comments
- The change in tests/vars/rh_distros_vars.yml goes in the opposite direction of the description/Ansible 2.20 guidance: you’re replacing ansible_facts['distribution'] with ansible_distribution, but with ANSIBLE_INJECT_FACT_VARS=false set in CI, you should be moving to ansible_facts['distribution'] everywhere instead of using the injected variable.
- Now that ANSIBLE_INJECT_FACT_VARS/SR_ANSIBLE_INJECT_FACT_VARS is being set in the workflows, consider centralizing or reusing this configuration (e.g., via a shared action or script) so the default doesn’t silently diverge between different CI jobs in the future.

---

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

• X
• Mastodon
• LinkedIn
• Facebook

_{Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.}