ci: use ANSIBLE_INJECT_FACT_VARS=false by default for testing

[richm]

Ansible 2.20 has deprecated the use of Ansible facts as variables. For
example, ansible_distribution is now deprecated in favor of
ansible_facts["distribution"]. This is due to making the default
setting INJECT_FACTS_AS_VARS=false. For now, this will create WARNING
messages, but in Ansible 2.24 it will be an error.

In order to ensure that commits and PRs conform to this, use
ANSIBLE_INJECT_FACT_VARS=false by default in our CI testing.

See https://docs.ansible.com/projects/ansible/latest/porting_guides/porting_guide_core_2.20.html#inject-facts-as-vars

Signed-off-by: Rich Megginson rmeggins@redhat.com

Summary by Sourcery

Align Ansible variable usage and CI configuration with the desired facts-as-vars behavior.

Enhancements:

• Update Red Hat distribution helper variables to use the Ansible distribution fact consistently in role and test vars.

CI:

• Set ANSIBLE_INJECT_FACT_VARS=false in GitHub Actions integration tests.
• Propagate SR_ANSIBLE_INJECT_FACT_VARS=false through the tft workflow environment for Terraform-based testing.

[sourcery-ai]

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

Configures CI and test environments to run Ansible with facts not injected as variables, and adjusts role variables accordingly to remain compatible under the new behavior.

Flow diagram for Ansible fact usage in bootloader role variables

flowchart TD
  A["Start CI test run"] --> B["Ansible collects facts from managed_host"]
  B --> C["SR_ANSIBLE_INJECT_FACT_VARS=false applied in CI"]
  C --> D["Ansible config INJECT_FACTS_AS_VARS=false"]
  D --> E["Evaluate role vars in vars/main.yml"]
  E --> F["__bootloader_rh_distros and __bootloader_rh_distros_fedora defined"]
  F --> G["__bootloader_is_rh_distro: ansible_distribution in __bootloader_rh_distros"]
  G --> H["__bootloader_is_rh_distro_fedora: ansible_distribution in __bootloader_rh_distros_fedora"]
  H --> I["Conditionals in tasks use these booleans"]
  I --> J["Tasks execute based on detected distribution type"]
  J --> K["End CI test run"]

Loading

File-Level Changes

Change	Details	Files
Align distro-detection variables with non-injected Ansible facts behavior.	Update Red Hat distro detection variables to reference the legacy ansible_distribution variable instead of ansible_facts['distribution'] in the main role vars. Mirror the same variable reference change in the test vars used for Red Hat distro detection.	vars/main.yml tests/vars/rh_distros_vars.yml
Ensure CI jobs run Ansible with ANSIBLE_INJECT_FACT_VARS disabled by default.	Set ANSIBLE_INJECT_FACT_VARS="false" in the qemu-kvm integration test GitHub Actions workflow environment. Propagate an SR_ANSIBLE_INJECT_FACT_VARS=false variable into the TFT workflow Terraform invocation so downstream jobs/tests also run with fact vars injection disabled.	.github/workflows/qemu-kvm-integration-tests.yml .github/workflows/tft.yml

---

Tips and commands

Interacting with Sourcery

• Trigger a new review: Comment @sourcery-ai review on the pull request.
• Continue discussions: Reply directly to Sourcery's review comments.
• Generate a GitHub issue from a review comment: Ask Sourcery to create an
  issue from a review comment by replying to it. You can also reply to a
  review comment with @sourcery-ai issue to create an issue from it.
• Generate a pull request title: Write @sourcery-ai anywhere in the pull
  request title to generate a title at any time. You can also comment
  @sourcery-ai title on the pull request to (re-)generate the title at any time.
• Generate a pull request summary: Write @sourcery-ai summary anywhere in
  the pull request body to generate a PR summary at any time exactly where you
  want it. You can also comment @sourcery-ai summary on the pull request to
  (re-)generate the summary at any time.
• Generate reviewer's guide: Comment @sourcery-ai guide on the pull
  request to (re-)generate the reviewer's guide at any time.
• Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
  pull request to resolve all Sourcery comments. Useful if you've already
  addressed all the comments and don't want to see them anymore.
• Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
  request to dismiss all existing Sourcery reviews. Especially useful if you
  want to start fresh with a new review - don't forget to comment
  @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

• Enable or disable review features such as the Sourcery-generated pull request
  summary, the reviewer's guide, and others.
• Change the review language.
• Add, remove or edit custom review instructions.
• Adjust other review settings.

Getting Help

• Contact our support team for questions or feedback.
• Visit our documentation for detailed guides and information.
• Keep in touch with the Sourcery team by following us on X/Twitter, LinkedIn or GitHub.

[sourcery-ai]

Hey - I've left some high level feedback:

• The variable changes in vars/main.yml and tests/vars/rh_distros_vars.yml switch from ansible_facts['distribution'] to ansible_distribution, which goes in the opposite direction of the PR description (facts-as-vars is what’s being deprecated); these should likely remain or be converted to the ansible_facts[...] style if the goal is to be future-proof with ANSIBLE_INJECT_FACT_VARS=false.
• In the tft.yml workflow you set SR_ANSIBLE_INJECT_FACT_VARS=false instead of ANSIBLE_INJECT_FACT_VARS=false; please double-check that the underlying tooling actually propagates SR_ANSIBLE_INJECT_FACT_VARS into the Ansible environment, otherwise this change will not have the intended effect.

Prompt for AI Agents

Please address the comments from this code review:

## Overall Comments
- The variable changes in `vars/main.yml` and `tests/vars/rh_distros_vars.yml` switch from `ansible_facts['distribution']` to `ansible_distribution`, which goes in the opposite direction of the PR description (facts-as-vars is what’s being deprecated); these should likely remain or be converted to the `ansible_facts[...]` style if the goal is to be future-proof with `ANSIBLE_INJECT_FACT_VARS=false`.
- In the `tft.yml` workflow you set `SR_ANSIBLE_INJECT_FACT_VARS=false` instead of `ANSIBLE_INJECT_FACT_VARS=false`; please double-check that the underlying tooling actually propagates `SR_ANSIBLE_INJECT_FACT_VARS` into the Ansible environment, otherwise this change will not have the intended effect.

---

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

• X
• Mastodon
• LinkedIn
• Facebook

_{Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.}