Fixed the examples argument parser problem of not handling booleans#43
Open
andrewcheelightstep wants to merge 1 commit intolightstep:masterfrom
Open
Fixed the examples argument parser problem of not handling booleans#43andrewcheelightstep wants to merge 1 commit intolightstep:masterfrom
andrewcheelightstep wants to merge 1 commit intolightstep:masterfrom
Conversation
Contributor
|
Thanks for the PR (and sorry for the delayed review). The change looks right, and the only thing I wonder is the default value - before this change, the expected default value was to use TLS, while with this change the default would be to not use it. Maybe we should rename it to |
Contributor
|
Agree with @carlos - it's just an example program, but |
Author
|
I have no problems with this. Is this something we can merge soon? |
frenchfrywpepper
added a commit
that referenced
this pull request
Sep 5, 2018
This was the default before my proto change. And I noticed this open PR #43 which had some feedback about that.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Modified the argument parser for the --use_tls argument because it wasn't parsing booleans correctly.