-
Notifications
You must be signed in to change notification settings - Fork 26
Add serde serializers for Bytes and Enums in protos #122
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
benthecarman
wants to merge
1
commit into
lightningdevkit:main
Choose a base branch
from
benthecarman:better-pretty-print
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+111
−0
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,61 @@ | ||
| // This file is Copyright its original authors, visible in version control | ||
| // history. | ||
| // | ||
| // This file is licensed under the Apache License, Version 2.0 <LICENSE-APACHE | ||
| // or http://www.apache.org/licenses/LICENSE-2.0> or the MIT license | ||
| // <LICENSE-MIT or http://opensource.org/licenses/MIT>, at your option. | ||
| // You may not use this file except in accordance with one or both of these | ||
| // licenses. | ||
|
|
||
| //! Custom serde serializers for proto types. | ||
| //! | ||
| //! These are used via `#[serde(serialize_with = "...")]` attributes on generated | ||
| //! proto fields to produce human-readable output (hex strings for bytes, enum | ||
| //! names for integer enum fields). | ||
|
|
||
| use serde::Serializer; | ||
|
|
||
| use crate::types::{PaymentDirection, PaymentStatus}; | ||
|
|
||
| /// Serializes `Option<prost::bytes::Bytes>` as a hex string (or null). | ||
| pub fn serialize_opt_bytes_hex<S>( | ||
| value: &Option<bytes::Bytes>, serializer: S, | ||
| ) -> Result<S::Ok, S::Error> | ||
| where | ||
| S: Serializer, | ||
| { | ||
| match value { | ||
| Some(bytes) => { | ||
| let hex: String = bytes.iter().map(|b| format!("{b:02x}")).collect(); | ||
| serializer.serialize_some(&hex) | ||
| }, | ||
| None => serializer.serialize_none(), | ||
| } | ||
| } | ||
|
|
||
| /// Serializes an `i32` payment direction field as its string name. | ||
| pub fn serialize_payment_direction<S>(value: &i32, serializer: S) -> Result<S::Ok, S::Error> | ||
| where | ||
| S: Serializer, | ||
| { | ||
| let name = match PaymentDirection::from_i32(*value) { | ||
| Some(PaymentDirection::Inbound) => PaymentDirection::Inbound.as_str_name(), | ||
| Some(PaymentDirection::Outbound) => PaymentDirection::Outbound.as_str_name(), | ||
| _ => "UNKNOWN", | ||
| }; | ||
| serializer.serialize_str(name) | ||
| } | ||
|
|
||
| /// Serializes an `i32` payment status field as its string name. | ||
| pub fn serialize_payment_status<S>(value: &i32, serializer: S) -> Result<S::Ok, S::Error> | ||
| where | ||
| S: Serializer, | ||
| { | ||
| let name = match PaymentStatus::from_i32(*value) { | ||
| Some(PaymentStatus::Pending) => PaymentStatus::Pending.as_str_name(), | ||
| Some(PaymentStatus::Succeeded) => PaymentStatus::Succeeded.as_str_name(), | ||
| Some(PaymentStatus::Failed) => PaymentStatus::Failed.as_str_name(), | ||
| _ => "UNKNOWN", | ||
| }; | ||
| serializer.serialize_str(name) | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we make use of the
stringifymacro instead of having to match each type/variant individually?