Record history more accurately#70
Draft
brycekbargar wants to merge 5 commits intolibrary-data-platform:release-v4.0.0from
Draft
Record history more accurately#70brycekbargar wants to merge 5 commits intolibrary-data-platform:release-v4.0.0from
brycekbargar wants to merge 5 commits intolibrary-data-platform:release-v4.0.0from
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
One thing that's come up a couple of times while running in alpha mode is that the history doesn't reflect what actually happens because it isn't updated in the same transaction as the download/transform. This changes the columns to be more informational as well as modifying the dashboard to be incrementally updated in transactions. This is also a lot cleaner as state doesn't have be maintained the whole runtime and can be distributed more easily.
While testing this and comparing with the existing data I noticed there were two regressions. The first was a bug with jagged json where only rows with all the nested objects would be fully transformed. The second had to do with the _version column some tables have which was losing the leading underscore. These are both fixed here.