Conversation
fixes libgit2gh-796 libgit2 already supports it.
|
I've now tested with libssh2 built against gcrypt. when attempting to use in-memory ssh key without a public key (as you can with OpenSSL), you get |
|
I'm pretty sure the previous error was because libgcrypt can't handle my private keys at all. When using a libssh2 with openssl, but without ssh memory credentials (???), I get |
| @repo.remotes.create("origin", ENV['GITTEST_REMOTE_SSH_URL']) | ||
|
|
||
| @repo.fetch("origin", { | ||
| credentials: ssh_key_credential_from_memory |
There was a problem hiding this comment.
This will work as long as we keep compiling against libssh2 which itself is built aginst openssl, but otherwise we'll start seeing errors in test.
2 participants
fixes gh-796
libgit2 already supports it.
I wrote the tests for it, but was unable to get any of the OnlineTests to work. I'm guessing I probably just don't fully understand what I'm supposed to put in the environment variables. I did test it for reals. And I also tested it with libgit2 not having libssh2 support (since ssh key from memory is an optional feature), and Rugged's extensions still compiles. I did not test it with a libgit2 with libssh2 support, but not support for ssh key from memory (presumably a crypto backend other than openssl?).