sqlite: Blob type for oid field and libgit2 allocation#20
Open
gumenikav wants to merge 1 commit intolibgit2:masterfrom
Open
sqlite: Blob type for oid field and libgit2 allocation#20gumenikav wants to merge 1 commit intolibgit2:masterfrom
gumenikav wants to merge 1 commit intolibgit2:masterfrom
Conversation
gumenikav
commented
Mar 6, 2017
gumenikav
commented
- Text field is not suitable for an oid data, because of an oid can contain null-symbols.
- The buffer should be allocated using the function git_odb_backend_malloc to ensure that it can be safely freed later
- Тhere is no need to copy data(SQLITE_TRANSIENT) since query to the database is done in the scope of the same function
* Memory allocation using git_odb_backend_malloc
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.