Distributed infinite element mesh building fixes #4394
+137
−42
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Figuring out neighbor pointers in distributed infinite element generation is hard enough that I want to just make find_neighbors do most of the work, but it'll be preliminary work that we can't safely assert parallel consistency on.
We never do parallel sweeps with infinite elements enabled in CI, but I did one and after a little work it passes.
|
Job Coverage, step Generate coverage on 483b23d wanted to post the following: Coverage
Warnings
This comment will be updated on new commits. |
||||||||||||||||||||||||||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's been a while since I manually (we don't have it in CI) ran a distributed-mesh sweep with infinite elements enabled; doing so in pursuit of #3759 revealed that miscellaneous_ex15 was written and merged after my last sweep and was not distributed-mesh compatible. Fixing misc ex15 (and applying the more extensive internal verification tests in #3759) revealed that misc ex15 triggered some long-standing bugs in distributed inf_elem_builder operation that I'd thought I'd fixed but that I really hadn't.
These commits fix both the example and the bugs it triggered on distributed meshes.