[Remove Vuetify from Studio] Convert collection modal tests to Vue Testing Library #5694
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👋 Thanks for contributing! We will assign a reviewer within the next two weeks. In the meantime, please ensure that:
We'll be in touch! 😊 |
vtushar06
reviewed
Feb 10, 2026
|
|
||
| expect(wrapper.vm.$route.name).toBe(RouteNames.CHANNEL_SETS); | ||
| }); | ||
| expect(screen.getByText('Field is required')).toBeInTheDocument(); |
Contributor
There was a problem hiding this comment.
This assertion depends on the exact validation copy. If the message changes but the validation behavior stays the same, this test will fail unnecessarily.
My suggestion is to assert the validation state instead (for example via a semantic role).
expect(screen.getByRole('alert')).toBeInTheDocument();
vtushar06
reviewed
Feb 10, 2026
| }); | ||
| expect(await screen.findByRole('heading', { name: 'Unsaved changes' })).toBeInTheDocument(); | ||
| expect( | ||
| screen.getByText('You will lose any unsaved changes. Are you sure you want to exit?'), |
Contributor
There was a problem hiding this comment.
Same I wanted to apply here .
expect(screen.getByRole('dialog')).toBeInTheDocument();
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Refactored channelSetModal.spec.js to use Vue Testing Library and focus on user-facing behavior instead of component internals.
Ran
pnpm test -- channelList/views/ChannelSet/tests/channelSetModal.spec.js
Ref:
Closes : #5686