Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -123,7 +123,7 @@
"babel-loader": "^10.0.0",
"circular-dependency-plugin": "^5.2.0",
"css-loader": "7.1.2",
"eslint": "^8.57.0",
"eslint": "^9.26.0",

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

blocking: This bumps eslint from 8.x to 9.x — a major version with significant breaking changes (flat config default, removed APIs, dropped formatters, changed rule defaults). No config migration was performed:

  • The project uses legacy .eslintrc.js (not the new eslint.config.js flat config)
  • No ESLINT_USE_FLAT_CONFIG=false environment variable is set
  • No code changes accompany this version bump

CI passes only because kolibri-format@1.0.1 bundles its own eslint@8.57.1 — the top-level eslint@9.26.0 is never actually invoked. This creates a confusing split-dependency state where the declared version doesn't match what's used.

Recommend closing this PR. When the project is ready to migrate to ESLint 9, it should be done as a coordinated effort that includes:

  1. Updating kolibri-format to support ESLint 9
  2. Migrating .eslintrc.js to eslint.config.js (or setting ESLINT_USE_FLAT_CONFIG=false)
  3. Addressing any rule changes or removed APIs

"eslint-config-prettier": "^10.1.8",
"eslint-import-resolver-webpack": "0.13.10",
"eslint-plugin-import": "^2.31.0",
Expand Down
Loading