fix(ip6tc): ipv6 interface name with 15 chars is too big#348
Merged
ldx merged 2 commits intoldx:masterfrom Mar 4, 2025
Merged
Conversation
Owner
This looks good, thank you! Can you also
|
94d0a6d to
e2bfdeb
Compare
Owner
|
Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


IPv4 and IPv6 code for getting in/out interface name is different, while IPv6 contained the following bug if the interface name is 15 characters:
for i in range(_IFNAMSIZ):will never run theelsesection which deletes the last null character usingintf = intf[:-1]if the interface name is 15 chars.I aligned the logic to use the same one as ipv4, since both function are doing the same thing, just in a different way
before the fix:


after the fix: