Add CI workflows for building and running the example app#48
Merged
kinyoklion merged 3 commits intomainfrom Mar 3, 2026
Merged
Add CI workflows for building and running the example app#48kinyoklion merged 3 commits intomainfrom
kinyoklion merged 3 commits intomainfrom
Conversation
Co-Authored-By: rlamb@launchdarkly.com <rlamb@launchdarkly.com>
Contributor
Author
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
kinyoklion
reviewed
Mar 3, 2026
Co-Authored-By: rlamb@launchdarkly.com <rlamb@launchdarkly.com>
kinyoklion
approved these changes
Mar 3, 2026
tanderson-ld
approved these changes
Mar 3, 2026
kinyoklion
reviewed
Mar 3, 2026
Co-Authored-By: rlamb@launchdarkly.com <rlamb@launchdarkly.com>
pkaeding
approved these changes
Mar 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add CI workflows for building and running the example app
Summary
Updates the existing build workflow (
ci.yml) and adds a new run workflow (run.yml) for thehello-macosproject, following the same pattern as hello-android PR #13.ci.ymlchanges:actions/checkoutto SHA with version comment (v4.2.2)setup-xcodeSHA (v1.6.0)-workspace 'hello-macos.xcworkspace'to thexcodebuildcommandschedulecron trigger (preservesfeat/**branch triggers)macos-buildtobuildrun.yml(new):release-secretssed(using|delimiter for safety)xcodebuildopen, waits 15s, then uses AppleScript (osascript) to read the window text andgrepfor"feature flag evaluates to true"Action versions used
actions/checkout11bd71901bbe5b1630ceea73d27597364c9af683maxim-lobanov/setup-xcode60606e260d2fc5762a71e64e74b2174e8ea3c8bdlaunchdarkly/gh-actions/actions/release-secretsbbbbbda684f500766264e7fe327668094ba83d1cUpdates since last revision
feat/**branch triggers inci.ymlfor bothpushandpull_request(per reviewer feedback).seddelimiter from/to|in both key injection commands for safer substitution (per reviewer feedback).Review & Testing Checklist for Human
CI is currently green (build, run, and semgrep all pass), but the following items warrant manual verification:
run.ymlverification usesosascriptwithSystem Eventsto read UI text. While this passed CI onmacos-14, it relies on the runner granting accessibility permissions to the shell. If GitHub updates runner configurations this could break. This is the highest-risk item.process "hello-macos"— confirm this consistently matches the actual process name when the.appbundle is launched. It may vary across Xcode/macOS versions.schedulecron trigger: The originalci.ymlhad a daily cron schedule (0 9 * * *). This was removed to align with thehello-androidpattern. Confirm this is desired.Suggested test plan: Trigger the
run.ymlworkflow manually 2–3 times to confirm the AppleScript-based verification is stable and not flaky due to timing or permissions.Notes
macos-14runner.release-secretspattern used in other hello-app repos.Link to Devin Session: https://app.devin.ai/sessions/cea1bda349b740048511ed04e7be5c61
Requested by: rlamb@launchdarkly.com