Update hello-js to use @launchdarkly/js-client-sdk v4#14
Open
Update hello-js to use @launchdarkly/js-client-sdk v4#14
Conversation
- Replace launchdarkly-js-client-sdk@3 with @launchdarkly/js-client-sdk@4 - Use ES module import instead of global script tag - Use createClient() + client.start() instead of LDClient.initialize() - Handle initialization via start() promise result - Update README to reference v4 SDK Co-Authored-By: Steven Zhang <szhang@launchdarkly.com>
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Migrates the hello-js example application from
launchdarkly-js-client-sdk@3to@launchdarkly/js-client-sdk@4.Key changes:
<script src="...@3">tag with a<script type="module">using an ESM import from unpkgLDClient.initialize(clientSideID, context)withcreateClient(clientSideID, context)+await client.start()on('initialized'),on('failed'),on('ready')) with the promise-basedstart()result patternon('change', render)for reacting to flag changesrender()function that existed in the originalReview & Testing Checklist for Human
index.htmlin a browser with a realclientSideIDset and verify the SDK initializes, evaluates the flag, and displays the result. This was not tested during development.on('change', render)listener).<script type="module">with a bare unpkg URL. Confirm no CORS or module resolution issues.start()behavior on failure: Set an invalidclientSideIDand verify the "SDK failed to initialize" message appears (theelsebranch).Notes
@launchdarkly/js-client-sdk) only ships ESM and CJS bundles (no UMD/IIFE), so the example now requires<script type="module">instead of a classic script tag. This means it won't work in very old browsers that don't support ES modules.