Fix pattern matching in do_latest_file_size_by_head#162
Open
mattwynne wants to merge 1 commit intolau:masterfrom
Open
Fix pattern matching in do_latest_file_size_by_head#162mattwynne wants to merge 1 commit intolau:masterfrom
mattwynne wants to merge 1 commit intolau:masterfrom
Conversation
Fix where pattern matching expected a flat
3-tuple {tag, status, headers} but HTTPClient behaviour
returns nested structure {:ok, {status, headers}}.
This causes a FunctionClauseError when calling
latest_file_size_by_head, silently falling back to GET requests.
Adds sham to allow for testing
Co-authored-by: Ryan Spore <ryan@mechanical-orchard.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix where pattern matching expected a flat 3-tuple
{tag, status, headers}but HTTPClient behaviour returns nested structure{:ok, {status, headers}}.This causes a FunctionClauseError when calling
latest_file_size_by_head, silently falling back to GET requests.Adds Sham (and Bandit) as test-only deps to allow for testing the change.
Licensing: This contribution is made by employees of Mechanical Orchard, Inc. under the terms of the project’s license.