Rename air and add description to air setting in printer#250
Rename air and add description to air setting in printer#250IceTank wants to merge 4 commits intolambda-client:1.21.11from
Conversation
|
i think "Air" makes more sense as its the most accurate. All blocks outside of schematics are considered air, and if air is disabled, it ignores air in the schematic too. Maybe just a better description but keep the original name? |
|
Added another check to only interact with blocks that are inside any loaded schematic |
|
I added another check to only consider blocks inside active placements for printing. This also prevents the printer from breaking shit outside the schematic. Air setting now breaks any blocks that do not match the schematic and should be air. |
beanbag44
left a comment
beanbag44
left a comment
There was a problem hiding this comment.
really nice, been wanting to fix that for a while. Just one small improvement
| private fun inSchematic(pos: BlockPos): Boolean { | ||
| val placementManager = DataManager.getSchematicPlacementManager() | ||
| placementManager?.getAllPlacementsTouchingChunk(pos)?.forEach { | ||
| if (it.placement.isEnabled && it.bb.containsPos(pos)) return true |
There was a problem hiding this comment.
could use .any {} instead of returning true in the for loop and then returning false at the end if it reaches that point
2 participants
Pull Request Guidelines
This is a template, modify before submitting your PR
Ensure that your title is concise and has all the necessary information
Examples:
Feat: Add new block typesFix: Crash on startupFix: GUI does not renderRef: Optimize rendering engineNew pre-processor for pathfindingFix inconsistency with the structureIssue Link
If your PR addresses one or more issues, be sure to link them. Use appropriate keywords like
closes,fixes, orresolvesto automatically close the linked issues when the PR is merged.Examples:
This PR fixes a memory leak in foo() and closes #4. It also resolves #5, which is a duplicate issue.Closes #1, resolves #2, and fixes #3Fixes #1Description
Provide a concise yet detailed summary of the changes introduced in this PR. Include the purpose of the changes and any relevant context.
Examples:
This pull request improves compatibility with version 1.21.4 by addressing rendering issues and adding support for new block types.Refactors the rendering engine to enhance performance and reduce memory usage.Adds a new feature for biome-specific block spawning to align with gameplay mechanics introduced in version 1.20.4.Checklist Before Submitting
To ensure the quality and maintainability of your PR, confirm the following before submission: