Open
Conversation
mozesl-nokia
requested review from
efiacor,
kispaljr and
liamfallon
as code owners
✅ Deploy Preview for kptdocs ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
mozesl-nokia
force-pushed
the
simple-resolve-func
branch
from
47db917 to
19f8004
Compare
Signed-off-by: Mózes László Máté <laszlo.mozes@nokia.com>
Contributor
There was a problem hiding this comment.
Pull request overview
This PR simplifies image resolution by refactoring ImageResolveFunc/ResolveToImageForCLIFunc to remove the context.Context parameter, error return, and unnecessary RunnerOptions receiver, and then updates call sites accordingly.
Changes:
- Refactor
ImageResolveFunctofunc(image string) stringand updateResolveToImageForCLIFuncaccordingly. - Update various runners/commands to call
ResolveToImage(...)without context/error handling. - Adjust tests and small formatting accordingly.
Reviewed changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| thirdparty/kyaml/runfn/runfn.go | Update function image resolution call site to new ResolveToImage(image) signature. |
| thirdparty/cmdconfig/commands/cmdeval/cmdeval.go | Remove ctx plumbing for CLI function config image resolution and update call site(s). |
| pkg/test/runner/runner.go | Minor formatting (blank line removal). |
| pkg/lib/runneroptions/runneroptions.go | Core API change: simplify resolver function type and factory; remove context/error/receiver. |
| internal/fnruntime/runner_test.go | Update test to reflect resolver no longer returns an error. |
| internal/fnruntime/runner.go | Update runner initialization to use new resolver signature without context/error. |
| commands/fn/doc/cmdfndoc.go | Update doc command to use new resolver factory and signature; remove use of cobra context. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review. Take the survey.
|
|
||
| // ImageResolveFunc is the type for a function that can resolve a partial image to a (more) fully-qualified name | ||
| type ImageResolveFunc func(ctx context.Context, image string) (string, error) | ||
| type ImageResolveFunc func(image string) string |
Contributor
Author
There was a problem hiding this comment.
Are we expecting any users other than Porch (where the need for this change comes from)?
@liamfallon @efiacor
| // If the function is a catalog function, it prepends `prefix`, e.g. "set-namespace:v0.1" --> prefix + "set-namespace:v0.1". | ||
| // A "/" is appended to `prefix` if it is not an empty string and does not end with a "/". | ||
| func (opts *RunnerOptions) ResolveToImageForCLIFunc(prefix string) func(_ context.Context, image string) (string, error) { | ||
| func ResolveToImageForCLIFunc(prefix string) func(image string) string { |
dosubot
bot
added
size:M
mozesl-nokia
force-pushed
the
simple-resolve-func
branch
from
75b32ff to
571beaf
Compare
Signed-off-by: Mózes László Máté <laszlo.mozes@nokia.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ImageResolveFuncandResolveToImageForCLIFuncwere overly complicated and unnecessary hadRunnerOptionsas a receiver.Removed the context arg, the error from the return value and the receiver.