chore: rework i18n for js to avoid async and duplication#668
Merged
darcywong00 merged 2 commits intofeat/search-i18nfrom Mar 2, 2026
Merged
chore: rework i18n for js to avoid async and duplication#668darcywong00 merged 2 commits intofeat/search-i18nfrom
darcywong00 merged 2 commits intofeat/search-i18nfrom
Conversation
Moves the responsibility for determining locale fallback server-side, so that we can avoid async pollution and have just a single responsible module for locale fallback. Strings are injected into a <script> data element as JSON, reducing the number of network round trips. Test-bot: skip
User Test ResultsTest specification and instructions User tests are not required |
darcywong00
approved these changes
Feb 25, 2026
Contributor
darcywong00
left a comment
darcywong00
left a comment
There was a problem hiding this comment.
nice - this does make things cleaner!
darcywong00
reviewed
Feb 25, 2026
darcywong00
reviewed
Feb 26, 2026
Contributor
|
I'll go ahead and merge this into the base PR #658 and address remaining comments there. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Moves the responsibility for determining locale fallback server-side, so that we can avoid async pollution and have just a single responsible module for locale fallback.
Strings are injected into a <script> data element as JSON, reducing the number of network round trips.
@darcywong00 happy to discuss this further as required
Test-bot: skip