Skip to content

Comments

Issue 782 dhcp ntp dns#1410

Open
saba8814 wants to merge 1 commit intokernelkit:mainfrom
saba8814:issue-782-dhcp-ntp-dns
Open

Issue 782 dhcp ntp dns#1410
saba8814 wants to merge 1 commit intokernelkit:mainfrom
saba8814:issue-782-dhcp-ntp-dns

Conversation

@saba8814
Copy link
Contributor

@saba8814 saba8814 commented Feb 21, 2026

Description

Checklist

Tick relevant boxes, this PR is-a or has-a:

  • Bugfix
    • Regression tests
    • ChangeLog updates (for next release)
  • Feature
    • YANG model change => revision updated?
    • Regression tests added?
    • ChangeLog updates (for next release)
    • Documentation added?
  • Test changes
    • Checked in changed Readme.adoc (make test-spec)
    • Added new test to group Readme.adoc and yaml file
  • Code style update (formatting, renaming)
  • Refactoring (please detail in commit messages)
  • Build related changes
  • Documentation content changes
    • ChangeLog updated (for major changes)
  • Other (please describe):


==== Sequence

. Stage 1 & 2: Set up topology and configure static IP on client
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not how we write the sequence, skip the stage part

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated in new version.

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds a new integration test that verifies the combination of DHCP, NTP, and DNS functionality. Specifically, it tests that statically configured DNS and NTP servers are preserved (not lost) when a client also receives DNS and NTP server information from a DHCP server. The test validates that both the static and DHCP-provided servers coexist in the system's operational state.

Changes:

  • Added a new use case test for DHCP + NTP + DNS combination
  • Created topology files and test documentation
  • Updated test suite configuration to include the new test

Reviewed changes

Copilot reviewed 6 out of 7 changed files in this pull request and generated 5 comments.

Show a summary per file
File Description
test/case/use_case/dhcp_ntp_dns_combination/topology.svg SVG visualization of the test topology
test/case/use_case/dhcp_ntp_dns_combination/topology.dot DOT graph definition for the topology
test/case/use_case/dhcp_ntp_dns_combination/test.py Main test implementation verifying DNS/NTP server coexistence
test/case/use_case/dhcp_ntp_dns_combination/test.adoc Test documentation in AsciiDoc format
test/case/use_case/dhcp_ntp_dns_combination/Readme.adoc Test readme file (contains critical error)
test/case/use_case/all.yaml Updated to include the new test case
test/case/use_case/Readme.adoc Updated to reference the new test documentation

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copy link
Contributor

@troglobit troglobit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! I'd like to echo what @mattiaswal said in Discord; please squash all commits and force-push since it's all a logical unit.

@saba8814 saba8814 force-pushed the issue-782-dhcp-ntp-dns branch from f4c3c8a to 1a1d917 Compare February 22, 2026 14:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants