Conversation
|
|
||
| ==== Sequence | ||
|
|
||
| . Stage 1 & 2: Set up topology and configure static IP on client |
There was a problem hiding this comment.
This is not how we write the sequence, skip the stage part
There was a problem hiding this comment.
Updated in new version.
There was a problem hiding this comment.
Pull request overview
This PR adds a new integration test that verifies the combination of DHCP, NTP, and DNS functionality. Specifically, it tests that statically configured DNS and NTP servers are preserved (not lost) when a client also receives DNS and NTP server information from a DHCP server. The test validates that both the static and DHCP-provided servers coexist in the system's operational state.
Changes:
- Added a new use case test for DHCP + NTP + DNS combination
- Created topology files and test documentation
- Updated test suite configuration to include the new test
Reviewed changes
Copilot reviewed 6 out of 7 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
| test/case/use_case/dhcp_ntp_dns_combination/topology.svg | SVG visualization of the test topology |
| test/case/use_case/dhcp_ntp_dns_combination/topology.dot | DOT graph definition for the topology |
| test/case/use_case/dhcp_ntp_dns_combination/test.py | Main test implementation verifying DNS/NTP server coexistence |
| test/case/use_case/dhcp_ntp_dns_combination/test.adoc | Test documentation in AsciiDoc format |
| test/case/use_case/dhcp_ntp_dns_combination/Readme.adoc | Test readme file (contains critical error) |
| test/case/use_case/all.yaml | Updated to include the new test case |
| test/case/use_case/Readme.adoc | Updated to reference the new test documentation |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
troglobit
left a comment
There was a problem hiding this comment.
Looks great! I'd like to echo what @mattiaswal said in Discord; please squash all commits and force-push since it's all a logical unit.
f4c3c8a to
1a1d917
Compare
Description
Checklist
Tick relevant boxes, this PR is-a or has-a: