[kernel-869] exclude files from extensions #98
Conversation
archandatta
force-pushed
the
archand/kernel-869/exclude-files-from-extensions
branch
from
a9498e8 to
cf9bfed
Compare
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 2 potential issues.
Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable Autofix in the Cursor dashboard.
rgarcia
left a comment
rgarcia
left a comment
There was a problem hiding this comment.
thanks for the pr! left some comments on naming, code duplication, and making the util more generic. main concerns are around duplicating the existing ZipDirectory function and making the exclusion options more intuitive.
archandatta
force-pushed
the
archand/kernel-869/exclude-files-from-extensions
branch
from
88b7410 to
27ef5de
Compare
rgarcia
left a comment
rgarcia
left a comment
There was a problem hiding this comment.
looks good — prior feedback well addressed. nice cleanup consolidating into the existing ZipDirectory. couple minor nits.
|
|
||
| // Pre-flight size check | ||
| if in.Output != "json" { | ||
| pterm.Info.Println("Analyzing extension directory...") |
There was a problem hiding this comment.
nit: "Analyzing..." is misleading since we go straight to zipping. consider changing to "Compressing extension directory..." and dropping the "Zipping extension directory..." message on line 328 since they'd be redundant.
| } | ||
|
|
||
| if fileInfo.Size() > MaxExtensionSizeBytes { | ||
| pterm.Error.Printf("Extension bundle is too large: %s (max: 50MB)\n", |
There was a problem hiding this comment.
nit: the hardcoded "50MB" here could drift from MaxExtensionSizeBytes — consider using FormatBytes(MaxExtensionSizeBytes) instead.
2 participants
Note
Medium Risk
Moderate risk because it changes the core
ZipDirectoryAPI and behavior (new filtering + walker error handling), which affects deployment and extension uploads and could unintentionally omit required files or alter zip contents.Overview
Extension uploads now produce smaller, safer bundles.
extensions uploadzips directories with default exclusions (e.g.,node_modules,.git, test/spec files, logs) and enforces a 50MB max bundle size, printing the resulting archive size and actionable guidance when exceeded.Zipping API updated across the CLI.
util.ZipDirectorynow accepts optionalZipOptionsfor directory and filename-pattern exclusions and propagates directory-walk errors; all call sites (deploy,browsers extensions upload, etc.) are updated to passnilor the new default options. Addsutil.FormatBytesand new tests for zip exclusions and unzip behavior.Written by Cursor Bugbot for commit 27ef5de. This will update automatically on new commits. Configure here.