Add validations to groups form#39
Open
thestrabusiness wants to merge 3 commits intokernel-community:mainfrom
Open
Add validations to groups form#39thestrabusiness wants to merge 3 commits intokernel-community:mainfrom
thestrabusiness wants to merge 3 commits intokernel-community:mainfrom
Conversation
thestrabusiness
force-pushed
the
anthony/groups-validations
branch
from
75ad892 to
6721aa5
Compare
thestrabusiness
changed the title
simonkernel
suggested changes
Jun 16, 2022
Contributor
simonkernel
left a comment
simonkernel
left a comment
There was a problem hiding this comment.
Hi @thestrabusiness,
Thanks for working on this and apologizes for just getting to this now!
We have @mgorkove with PR #40 in flight right now as well which will impact the Form component and validation.
I like the general approach and we're sort of re-implementing validation and alerts in each app. It would be great to keep things generic where possible.
Not saying we have to be able to use right away, just if there's a path to eventually extract it so to just keep it in mind.
I'd say let's hold off until the autocomplete PR lands and apologies for the cross-over.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Address #32