Updated for usage with browsers not having 'module'#11
Open
simonc92 wants to merge 1 commit intojonpacker:masterfrom
simonc92:master
Open
Updated for usage with browsers not having 'module'#11simonc92 wants to merge 1 commit intojonpacker:masterfrom simonc92:master
simonc92 wants to merge 1 commit intojonpacker:masterfrom
simonc92:master
Conversation
Author
|
Btw. thanks for this nice piece of code. Great work! |
|
Yep, something along these lines is needed. Also possible: if (typeof module === 'object' && module.exports) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I had the problem that this "addon" was not able to run in browsers which scopre doesn't have "module". I fixed it by checking if the type of module is not undefined which prevents an "ReferenceError: module is not defined" and $.tap not able to work.