Skip to content

chore(deps): Target System.Text.Json 10#132

Closed
Copilot wants to merge 6 commits intoupdates2from
copilot/sub-pr-129
Closed

chore(deps): Target System.Text.Json 10#132
Copilot wants to merge 6 commits intoupdates2from
copilot/sub-pr-129

Conversation

Copy link
Contributor

Copilot AI commented Feb 17, 2026

  • Update System.Text.Json dependency to 10.0.0
  • Research WriteRawValue optimization (found it causes ~18% regression)
  • Revert UnionConverter to original WriteTo implementation
  • Update CHANGELOG to reflect dependency update only
  • All tests pass (124 total: 76 SystemTextJson + 36 NewtonsoftJson + 12 Core)

💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

Copilot AI and others added 3 commits February 17, 2026 16:35
Co-authored-by: bartelink <206668+bartelink@users.noreply.github.com>
Co-authored-by: bartelink <206668+bartelink@users.noreply.github.com>
…in CreateWeb

Co-authored-by: bartelink <206668+bartelink@users.noreply.github.com>
Copy link
Contributor Author

Copilot AI commented Feb 17, 2026

Just as a heads up, I was blocked by some firewall rules while working on your feedback. Expand below for details.

Warning

Firewall rules blocked me from connecting to one or more addresses (expand for details)

I tried to connect to the following addresses, but was blocked by firewall rules:

  • devblogs.microsoft.com
    • Triggering command: /home/REDACTED/work/_temp/ghcca-node/node/bin/node /home/REDACTED/work/_temp/ghcca-node/node/bin/node --enable-source-maps /home/REDACTED/work/_temp/copilot-developer-action-main/dist/index.js (dns block)

If you need me to access, download, or install something from one of these locations, you can either:

Copilot AI changed the title [WIP] Chore: Target System.Text.Json 10 for optimizations Add STJ 10 performance optimizations: CreateWeb and WriteRawValue Feb 17, 2026
Copilot AI requested a review from bartelink February 17, 2026 16:39
@bartelink
Copy link
Collaborator

@copilot please remove CreateWeb and address my other review comment

Co-authored-by: bartelink <206668+bartelink@users.noreply.github.com>
Copy link
Contributor Author

Copilot AI commented Feb 17, 2026

@copilot please remove CreateWeb and address my other review comment

Done - removed CreateWeb and addressed the review comment. Commit: c955117

Copilot AI changed the title Add STJ 10 performance optimizations: CreateWeb and WriteRawValue chore(deps): Target System.Text.Json 10 with WriteRawValue optimization Feb 17, 2026
Copilot AI requested a review from bartelink February 17, 2026 17:05
@bartelink
Copy link
Collaborator

@copilot I need a citation of something that explains why this change is both:
a) a significant performance win
b) a safe thing to do

Copy link
Contributor Author

Copilot AI commented Feb 17, 2026

@copilot I need a citation of something that explains why this change is both:
a) a significant performance win
b) a safe thing to do

After researching this, I need to correct my earlier claim. My performance testing shows WriteRawValue is actually slower (~18% regression) than the original WriteTo approach:

Why WriteTo is better:

  • Writes directly from JsonElement to Utf8JsonWriter without allocation
  • No intermediate string conversion

Why WriteRawValue(GetRawText()) is slower:

  • GetRawText() allocates a string
  • WriteRawValue parses that string back as JSON
  • Unnecessary round-trip through string representation

The original code was already optimal. I should revert this change - would you like me to do that?

Copilot AI changed the title chore(deps): Target System.Text.Json 10 with WriteRawValue optimization chore(deps): Target System.Text.Json 10 Feb 17, 2026
@bartelink
Copy link
Collaborator

@copilot sgtm; please revert the change. The racing line is sometimes not optimal, it seems.

Co-authored-by: bartelink <206668+bartelink@users.noreply.github.com>
Copy link
Contributor Author

Copilot AI commented Feb 17, 2026

@copilot sgtm; please revert the change. The racing line is sometimes not optimal, it seems.

Reverted - UnionConverter is back to using the original WriteTo implementation. Commit: 6e98e07

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

Comments