[release-1.29] Support disabling baggage-based peer metadata discovery based on metadata#6856
Merged
istio-testing merged 6 commits intoistio:release-1.29from Mar 2, 2026
Conversation
…data The issue with the current implementation of the baggage-based peer metadata discovery is that when via DestinationRule we configure PROXY or TLS, waypoint will use a transport socket different from RawBuffer (RawBuffer just sends bytes as-is without adding any protocol there). peer_metadata filters communicate with each other by injecting data into data stream, so these transport sockets interfere with that. As a quick fix, until we find a way to avoid injecting into data stream, I want to disable baggage based metadata discovery on cluster-by-cluster or endpoint-by-endpoint basis. It's not enough to just skip adding filters in the controlplane to achieve that, because connect_originate and inner_connect_originate listeners may be used by different clusters with different properties, so if we don't add peer_metadata filters to those at all, it would affect clusters where no TLS or PROXY protocol is configured. Thus to avoid that I want to be able to disable baggage-based metadata discovery via metadata. I use metadata object key `istio.peer_metadata` and field `disable_baggage_discovery` for the metadata. The upstream filter will check endpoint and cluster level metadata, while regular network filter will only check metadata on the StreamInfo level - that's because we expect the metadata to be passed using InternalUpstreamTransport to the regular network filter. NOTE: I separated implementation into header and source to make it easier to write unit tests. NOTE: I tested this implementation using integration tests from the main istio repo with baggage metadata discovery enabled, but this PR by itself is not enough - we also need to change pilot to generate the dynamic metadata. NOTE: It's part of the fix for http://github.com/istio/istio/issues/59117. Signed-off-by: Mikhail Krinkin <mkrinkin@microsoft.com>
… tests Signed-off-by: Mikhail Krinkin <mkrinkin@microsoft.com>
Signed-off-by: Mikhail Krinkin <mkrinkin@microsoft.com>
Signed-off-by: Mikhail Krinkin <mkrinkin@microsoft.com>
istio-testing
added
the
release-notes-none
istio-testing
added
the
size/XXL
Signed-off-by: Mikhail Krinkin <mkrinkin@microsoft.com>
Contributor
|
I'm looking into test failures on this cherry pick now. |
…-6851-to-release-1.29
Contributor
|
I/O error, will retry the test. |
Contributor
|
/test release-test-arm64 |
1 similar comment
Contributor
|
/test release-test-arm64 |
krinkinmu
approved these changes
Mar 2, 2026
PetrMc
approved these changes
Mar 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is an automated cherry-pick of #6851