Skip to content

[uss_quafilier] Set severity of Successful flight deletion to info during cleanup#1404

Open
the-glu wants to merge 1 commit intointeruss:mainfrom
Orbitalize:fix_1401_b
Open

[uss_quafilier] Set severity of Successful flight deletion to info during cleanup#1404
the-glu wants to merge 1 commit intointeruss:mainfrom
Orbitalize:fix_1401_b

Conversation

@the-glu
Copy link
Contributor

@the-glu the-glu commented Mar 26, 2026

This PR marks all flight deletion check during cleanup as informative, as failling the check may be considered informative, as described in #1401 .

Question: Should we perform the same changes for cleanup of others things, like OPs ?

Edit: This also contribute to #1400 to avoid stopping during flight cleanup


## Cleanup
### ⚠️ Successful flight deletion check
### ℹ️ Successful flight deletion check
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since the requirement DeleteFlightSuccess specifies that a USS must remove a flight when instructed, I don't think Low severity is an appropriate categorization of this failure. A requirement is violated, but that violation doesn't warrant stopping the test scenario/cleanup -- that seems to match the description of Medium severity, so I don't think we want to change the severity of this check (or any of the others where a requirement is violated but we still want to continue test scenario/cleanup execution).

Copy link
Contributor Author

@the-glu the-glu Mar 26, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, but then for #1401, for "probably shouldn't fail regardless of {NotPlanned, Closed} in any situation since this is merely cleanup.", what should we do with fails?

Because it could be for multiple reasons (either dues to USS not failling the specs or something else), should we make the test smarter to differentiate both cases?

### [Restore virtual USS availability test step](../set_uss_available.md)

### 🛑 Successful flight deletion check
### ℹ️ Successful flight deletion check
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While I agree High severity is inappropriate (we do not want to interrupt the cleanup), it seems like a requirement is violated so Low is inappropriate also -- it seems like Medium severity fits here.

@BenjaminPelletier
Copy link
Member

Question: Should we perform the same changes for cleanup of others things, like OPs ?

There should be very few circumstances in which a check during cleanup should have High severity, as failing that check will prevent all the rest of the cleanup.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants