fix: use system installed perf for flame graph data collection, if available#651
Merged
harp-intel merged 1 commit intomainfrom Mar 3, 2026
Merged
Conversation
…ailable Signed-off-by: Harper, Jason M <jason.m.harper@intel.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request updates the profiling script to prefer using the system-installed
perftool over the bundled version, aiming to reduce compatibility issues and crashes. All invocations ofperfare updated to use the selected executable, improving reliability across different kernel versions.Tool selection and reliability improvements:
perfbinary over the bundled one, verifying that the discovered binary is functional and not a wrapper that fails due to missing kernel tools. This helps avoid kernel incompatibility issues that can cause crashes. (internal/script/scripts.go)perf(for both frame pointer and dwarf profiling modes, as well as during data collapsing) now use the selectedPERF_CMDvariable instead of assumingperfis available in the current directory orPATH. (internal/script/scripts.go) [1] [2] [3]