Skip to content

fix: use async db in sim_round#237

Merged
Fraser999 merged 3 commits intomainfrom
fraser/eng-1944/fix-hang
Mar 6, 2026
Merged

fix: use async db in sim_round#237
Fraser999 merged 3 commits intomainfrom
fraser/eng-1944/fix-hang

Conversation

@Fraser999
Copy link
Contributor

@Fraser999 Fraser999 commented Mar 5, 2026

Description

This PR changes the builder in line with the change in sim_round to use async DB functions for the preflight checks.

Without this, the tokio runtime would become deadlocked due to many calls to block_in_place(|| handle.block_on(f)). See the related ticket for further info.

NOTE: This also includes a version bump to rc 5

Related Issue

ENG-1944

Testing

  • ad hoc testing via running a builder shows that this no longer locks up under load.
  • make fmt passes
  • make clippy passes
  • make test passes

Copy link
Contributor Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

@Fraser999 Fraser999 marked this pull request as ready for review March 6, 2026 22:47
@Fraser999 Fraser999 enabled auto-merge (squash) March 6, 2026 22:57
@Fraser999 Fraser999 merged commit 8bb0b79 into main Mar 6, 2026
6 checks passed
@Fraser999 Fraser999 deleted the fraser/eng-1944/fix-hang branch March 6, 2026 22:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants