refactor: Delete dead code in driver.rs#1664
Merged
randomPoison merged 3 commits intomasterfrom Mar 18, 2026
Merged
Conversation
Contributor
Author
I always squash and merge, so when it lands on master it'll only be a single commit. |
ahomescu
approved these changes
Mar 18, 2026
| } | ||
| } | ||
|
|
||
| // /// Various driver bits that we have lying around at the end of `phase_1_parse_input`. This is |
Contributor
There was a problem hiding this comment.
Oh you're deleting this code. I'm not sure why it was here in the first place, or later commented out. Did you check the git history?
Contributor
Author
There was a problem hiding this comment.
It got commented out in the same toolchain roll that made the other stuff unused, I think it was replaced by rustc internals but I didn't dig into it too deeply since the code has been dead for years.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
build_sessionandbuild_session_from_argsbecame dead code in 65d1abae9 back in 2019. Likewise, the commented out code has been sitting there since the same commit, so I think we're fine to delete all of this.