You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This collects information about the parent nodes of each AST node (except types). It's not currently used for anything, but could potentially be used to solve #1321, by allowing conversion functions across the transpiler to easily find the types of their parent nodes.
I don't think we should merge a massive change that isn't used for anything. Edit: unless we also want #1679, in which case this is a prerequisite and not an independent change.
There are also other things that this makes possible, not all of which have been considered yet necessarily. One thing that comes to mind is being able to completely replace ExprContext, so that all context information is available globally and no longer relies on passing things down the call stack. That may be a requirement for making a fix for #1321, since macro translation is done outside the call stack and thus doesn't currently know what context each of its expansions exists in.
EDIT: To illustrate, the ctx being passed here is almost certainly wrong, because it's the context of the current expansion site, and not of the MacroObject itself, nor of all expansion sites:
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
c_astsubmodules #1652.This collects information about the parent nodes of each AST node (except types). It's not currently used for anything, but could potentially be used to solve #1321, by allowing conversion functions across the transpiler to easily find the types of their parent nodes.