Explicitly error out on host-guest version mismatch#1252
Explicitly error out on host-guest version mismatch#1252ludfjig wants to merge 1 commit intohyperlight-dev:mainfrom
Conversation
Signed-off-by: Ludvig Liljenberg <4257730+ludfjig@users.noreply.github.com>
dblnz
left a comment
There was a problem hiding this comment.
This looks good, but do we want to match against the patch version also?
I think it would be better to ensure that the guest's major/minor are the same, but the patch version is greater or equal the host's version.
I thought about this, and then decided to be as conservative as possible, because this would limit some things we can update in patch versions. Maybe this is a good start, and then we can consider later whether we should relax it? |
Keeping it restrictive to start then relaxing later is a good option. Its harder to go the other way. |
Hyperlight currently provides no backwards compatibility guarantees for guests. We should therefore error out explicitly if someone loads an old guest with new host, as they ABI might no longer match.
This PR enforces that hyperlight-host version must match the guest's hyperlight-guest-bin version.
Closes #845