Draft
Conversation
004bd7d to
df09eaa
Compare
df09eaa to
73d6b4b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Here we add a new
data:pg:waitcommand, similar toaddons:waitandpg:wait, specific for Advanced databases.The implementation was mostly copied from https://github.com/heroku/heroku-cli-plugin-data-beta/pull/176, converted to
@oclif/corev4 and ESM, with minor refactor and fixes.This is targeted right now to be merged against
v11.0.0branch, but we really be merging this tomainafterv11.0.0branch has been merged tomainand the final Heroku CLI v11.0.0 released. We're targeting to merge and release this soon after that onv11.1.0. We're keeping this as a draft PR until that time to avoid merging accidentally onv11.0.0.Type of Change
Breaking Changes (major semver update)
!after your change type to denote a changeFeature Additions (minor semver update)
Patch Updates (patch semver update)
Testing
Steps
npm install && npm run build../bin/run data:pg:create -a <test-app-name> --as ADVANCED_DB./bin/run data:pg:wait ADVANCED_DB -a <test-app-name> --wait-interval 15Screenshots (if applicable)
Related Issues
GUS work item: W-21411625