Skip to content

fix(mmio): allow compiling with multiple devices#2340

Open
mkroening wants to merge 2 commits intomainfrom
clippy-multiple-virtio
Open

fix(mmio): allow compiling with multiple devices#2340
mkroening wants to merge 2 commits intomainfrom
clippy-multiple-virtio

Conversation

@mkroening
Copy link
Member

No description provided.

@mkroening mkroening self-assigned this Mar 18, 2026
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Benchmark Results

Details
Benchmark Current: 0fedcbb Previous: 16c32e5 Performance Ratio
startup_benchmark Build Time 86.55 s 86.78 s 1.00
startup_benchmark File Size 0.75 MB 0.75 MB 1.00
Startup Time - 1 core 0.94 s (±0.02 s) 0.93 s (±0.03 s) 1.00
Startup Time - 2 cores 0.94 s (±0.04 s) 0.94 s (±0.03 s) 1.00
Startup Time - 4 cores 0.97 s (±0.03 s) 0.96 s (±0.03 s) 1.02
multithreaded_benchmark Build Time 90.27 s 90.00 s 1.00
multithreaded_benchmark File Size 0.86 MB 0.86 MB 1.00
Multithreaded Pi Efficiency - 2 Threads 87.85 % (±7.47 %) 88.72 % (±8.70 %) 0.99
Multithreaded Pi Efficiency - 4 Threads 43.88 % (±3.42 %) 44.14 % (±3.80 %) 0.99
Multithreaded Pi Efficiency - 8 Threads 25.22 % (±1.69 %) 25.68 % (±2.52 %) 0.98
micro_benchmarks Build Time 98.52 s 92.28 s 1.07
micro_benchmarks File Size 0.86 MB 0.86 MB 1.00
Scheduling time - 1 thread 68.31 ticks (±4.42 ticks) 64.77 ticks (±3.40 ticks) 1.05
Scheduling time - 2 threads 37.13 ticks (±3.94 ticks) 34.31 ticks (±2.99 ticks) 1.08
Micro - Time for syscall (getpid) 3.08 ticks (±0.25 ticks) 2.98 ticks (±0.21 ticks) 1.04
Memcpy speed - (built_in) block size 4096 62786.21 MByte/s (±44981.73 MByte/s) 63737.79 MByte/s (±45358.44 MByte/s) 0.99
Memcpy speed - (built_in) block size 1048576 29675.45 MByte/s (±24809.91 MByte/s) 29637.98 MByte/s (±24460.26 MByte/s) 1.00
Memcpy speed - (built_in) block size 16777216 25199.11 MByte/s (±21183.63 MByte/s) 28457.54 MByte/s (±23730.25 MByte/s) 0.89
Memset speed - (built_in) block size 4096 63493.35 MByte/s (±45429.66 MByte/s) 64630.09 MByte/s (±46006.03 MByte/s) 0.98
Memset speed - (built_in) block size 1048576 30470.45 MByte/s (±25251.16 MByte/s) 30406.17 MByte/s (±24893.36 MByte/s) 1.00
Memset speed - (built_in) block size 16777216 25981.04 MByte/s (±21682.29 MByte/s) 29216.69 MByte/s (±24152.86 MByte/s) 0.89
Memcpy speed - (rust) block size 4096 57479.33 MByte/s (±41877.42 MByte/s) 59726.61 MByte/s (±43827.85 MByte/s) 0.96
Memcpy speed - (rust) block size 1048576 29761.09 MByte/s (±24793.12 MByte/s) 29391.75 MByte/s (±24319.07 MByte/s) 1.01
Memcpy speed - (rust) block size 16777216 25021.10 MByte/s (±21092.18 MByte/s) 28350.56 MByte/s (±23626.64 MByte/s) 0.88
Memset speed - (rust) block size 4096 58725.49 MByte/s (±42709.87 MByte/s) 60177.77 MByte/s (±44076.46 MByte/s) 0.98
Memset speed - (rust) block size 1048576 30571.81 MByte/s (±25237.27 MByte/s) 30145.63 MByte/s (±24756.22 MByte/s) 1.01
Memset speed - (rust) block size 16777216 25789.16 MByte/s (±21579.92 MByte/s) 29120.62 MByte/s (±24059.81 MByte/s) 0.89
alloc_benchmarks Build Time 93.60 s 91.67 s 1.02
alloc_benchmarks File Size 0.82 MB 0.82 MB 1.00
Allocations - Allocation success 100.00 % 100.00 % 1
Allocations - Deallocation success 100.00 % 100.00 % 1
Allocations - Pre-fail Allocations 100.00 % 100.00 % 1
Allocations - Average Allocation time 16700.35 Ticks (±330.74 Ticks) 16939.35 Ticks (±451.19 Ticks) 0.99
Allocations - Average Allocation time (no fail) 16700.35 Ticks (±330.74 Ticks) 16939.35 Ticks (±451.19 Ticks) 0.99
Allocations - Average Deallocation time 1272.88 Ticks (±733.03 Ticks) 1327.70 Ticks (±757.73 Ticks) 0.96
mutex_benchmark Build Time 92.82 s 96.06 s 0.97
mutex_benchmark File Size 0.86 MB 0.86 MB 1.00
Mutex Stress Test Average Time per Iteration - 1 Threads 12.98 ns (±0.76 ns) 13.44 ns (±0.80 ns) 0.97
Mutex Stress Test Average Time per Iteration - 2 Threads 22.28 ns (±14.94 ns) 21.38 ns (±10.67 ns) 1.04

This comment was automatically generated by workflow using github-action-benchmark.

@mkroening mkroening changed the title ci: run clippy with multiple virtio devices fix: allow compiling with multiple MMIO devices Mar 18, 2026
@mkroening mkroening changed the title fix: allow compiling with multiple MMIO devices fix(mmio): allow compiling with multiple devices Mar 18, 2026
@mkroening mkroening force-pushed the clippy-multiple-virtio branch from a0baaf4 to 0fedcbb Compare March 18, 2026 17:44
@mkroening mkroening marked this pull request as ready for review March 18, 2026 17:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant