Integrate Boost.Json code for further usage #1656
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## feature_boost_json #1656 +/- ##
=====================================================
Coverage ? 80.35%
=====================================================
Files ? 350
Lines ? 14041
Branches ? 1515
=====================================================
Hits ? 11282
Misses ? 2145
Partials ? 614 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
rustam-gamidov-here
force-pushed
the
task/ocmam-442-integrate-boost-json
branch
20 times, most recently
from
657ff94 to
3a1a795
Compare
.github/workflows/psv_pipelines.yml
Outdated
| - name: Check out repository | ||
| uses: actions/checkout@v4 | ||
| - name: Install Ubuntu dependencies | ||
| run: sudo apt-get update && sudo apt-get install -y libboost-all-dev ccache libssl-dev libcurl4-openssl-dev --no-install-recommends |
Contributor
There was a problem hiding this comment.
Would be nice to remove libboost-all-dev and rely on our mechanism for fetching specified version
Collaborator
Author
There was a problem hiding this comment.
I made the job first and it failed https://github.com/heremaps/here-data-sdk-cpp/actions/runs/21821084609/job/62954267560
And according to https://packages.ubuntu.com ubuntu 22.04 has boost 1.74 in the list so we are downloading boost quite often
rustam-gamidov-here
force-pushed
the
task/ocmam-442-integrate-boost-json
branch
2 times, most recently
from
96d7c8e to
775f744
Compare
rustam-gamidov-here
changed the base branch from
master
to
feature_boost_json
No conversion just getting it into the build process Relates-To: OCMAM-442 Signed-off-by: Rustam Gamidov <ext-rustam.gamidov@here.com>
Initially not all code in boost json has proper wrappers for no exception builds Relates-To: OCMAM-442 Signed-off-by: Rustam Gamidov <ext-rustam.gamidov@here.com>
rustam-gamidov-here
force-pushed
the
task/ocmam-442-integrate-boost-json
branch
from
775f744 to
09b1fc7
Compare
Collaborator
Author
|
Closing in favour of #1662 as it has been decided to use boost 1.82 for now |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No conversion just getting it into the build process
Relates-To: OCMAM-442