Improve error message for proxy connection failures#155
Draft
Improve error message for proxy connection failures#155
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note - this is only for me to play with, I opened it with Copilot Workspace without looking closely at what it did. I'm not expecting anyone else to review it in its current form.
Related to #84
Implements enhanced error handling for proxy connection failures across the HTTP library, specifically targeting scenarios where the proxy mentioned in
http_proxyis down.ErrorProxyConnectioninNetwork/Stream.hsto specifically handle proxy connection errors, improving error specificity and clarity for such issues.Network/StreamSocket.hsto detect and report proxy connection failures, utilizing the newErrorProxyConnectionerror type. This includes handling specific socket error codes related to proxy connection failures.Network/HTTP.hsto include the updated error handling mechanisms fromNetwork/Stream.hsandNetwork/StreamSocket.hs, ensuring that proxy connection errors are correctly reported and logged, enhancing the overall robustness of the library in handling network-related errors.For more details, open the Copilot Workspace session.