Pin LLVM versions inside the repository #8942
Open
+968
−126
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexreinking
requested review from
abadams,
derek-gerstmann,
shoaibkamil and
slomp
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR, along with some soon-to-be implemented changes to the buildbots effectively pins the LLVM versions we are using inside the repository. Follow up work will create a GitHub App / bot that periodically triggers new LLVM main builds, and opens a PR to bump the pointer (a la dependabot). This gives us the ability to test PRs without worrying what tomorrow's LLVM version might do to us.
One notable change: we are replacing
requirements.txtwithuv.lock, which has the richer structure needed to communicate the "only one version of LLVM may be installed" constraints.