Skip to content

Use designated initializer for NimBLEScan parameters and conditionally set disable_observer_mode #400

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
h2zero merged 3 commits into from
Mar 14, 2026
+15 −3
Merged

Use designated initializer for NimBLEScan parameters and conditionally set disable_observer_mode #400

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
5d3eb65
Use designated initializer for NimBLEScan::m_scanParams and guard dis…
stdstijn Mar 12, 2026
1606fb5
Conditionally guard disable_observer_mode behind ESP_PLATFORM and CON…
stdstijn Mar 13, 2026
d52951e
Restore comment for disable_observer_mode field
stdstijn Mar 13, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 15 additions & 3 deletions src/NimBLEScan.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,10 +32,22 @@ static NimBLEScanCallbacks defaultScanCallbacks;
*/
NimBLEScan::NimBLEScan()
: m_pScanCallbacks{&defaultScanCallbacks},
// default interval + window, no whitelist scan filter,not limited scan, no scan response, filter_duplicates
m_scanParams{0, 0, BLE_HCI_SCAN_FILT_NO_WL, 0, 1, 1},
m_scanParams{
.itvl = 0, // default interval
.window = 0, // default window
.filter_policy = BLE_HCI_SCAN_FILT_NO_WL, // no whitelist scan filter
.limited = 0, // no limited scan
.passive = 1, // no scan response
.filter_duplicates = 1, // filter duplicates
# if defined(ESP_PLATFORM) && !defined(CONFIG_USING_NIMBLE_COMPONENT)
# if ESP_IDF_VERSION >= ESP_IDF_VERSION_VAL(5, 4, 2)
.disable_observer_mode = 0, // observer role enabled
# endif
# endif
},
m_pTaskData{nullptr},
m_maxResults{0xFF} {}
m_maxResults{0xFF} {
}

/**
* @brief Scan destructor, release any allocated resources.
Expand Down
Loading