Make stream class MCU and OS agnostic by h2zero · Pull Request #1109 · h2zero/NimBLE-Arduino

h2zero · 2026-03-12T20:27:46Z

No description provided.

Copilot

Pull request overview

This PR refactors the NimBLEStream implementation to remove ESP/FreeRTOS-specific dependencies and rely on NimBLE’s NPL primitives so the stream can work across different MCUs / OS ports.

Changes:

Replaced FreeRTOS ringbuffer + TX task with an NPL mutex-protected byte ring buffer and event-queue-driven TX draining.
Updated stream lifecycle to be driven from init() (server/client) rather than requiring an external begin().
Added a syscfg/nimconfig option intended to control stream debug log emission.

Reviewed changes

Copilot reviewed 8 out of 8 changed files in this pull request and generated 10 comments.

Show a summary per file

File	Description
src/syscfg/syscfg.h	Adds default config for stream debug log enablement.
src/nimconfig.h	Documents the new stream debug log config; minor ESP config formatting.
src/NimBLEStream.h	Makes the stream header platform-agnostic; updates API and internal structure.
src/NimBLEStream.cpp	Implements NPL-based buffering and TX draining; updates server/client send logic and UART logging output.
examples/STREAM_EXAMPLES.md	Removes FreeRTOS task tuning notes; still documents stream configuration.
examples/NimBLE_Stream_Server/NimBLE_Stream_Server.ino	Updates example usage to `ready()` and removes explicit `begin()`.
examples/NimBLE_Stream_Echo/NimBLE_Stream_Echo.ino	Removes explicit `begin()` and updates readiness check.
examples/NimBLE_Stream_Client/NimBLE_Stream_Client.ino	Removes explicit `begin()` after client init.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

You can also share your feedback on Copilot code review. Take the survey.

examples/NimBLE_Stream_Server/NimBLE_Stream_Server.ino

src/NimBLEStream.h

examples/NimBLE_Stream_Echo/NimBLE_Stream_Echo.ino

src/NimBLEStream.cpp

examples/STREAM_EXAMPLES.md

src/NimBLEStream.cpp

Copilot

Pull request overview

Copilot reviewed 8 out of 8 changed files in this pull request and generated 7 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

You can also share your feedback on Copilot code review. Take the survey.

src/NimBLEStream.h

src/NimBLEStream.cpp

examples/STREAM_EXAMPLES.md

src/nimconfig.h

src/NimBLEStream.h

Copilot

Pull request overview

Copilot reviewed 8 out of 8 changed files in this pull request and generated 5 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

You can also share your feedback on Copilot code review. Take the survey.

src/NimBLEStream.cpp

src/NimBLEStream.h

Copilot

Pull request overview

Copilot reviewed 6 out of 7 changed files in this pull request and generated 4 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

You can also share your feedback on Copilot code review. Take the survey.

src/NimBLEStream.cpp

src/NimBLEStream.h

src/NimBLEStream.cpp

Copilot

Pull request overview

Copilot reviewed 8 out of 9 changed files in this pull request and generated 4 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

You can also share your feedback on Copilot code review. Take the survey.

src/NimBLEStream.h

src/NimBLEStream.cpp

Copilot

Pull request overview

Copilot reviewed 8 out of 9 changed files in this pull request and generated 4 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

You can also share your feedback on Copilot code review. Take the survey.

src/NimBLEStream.cpp

Copilot

Pull request overview

Copilot reviewed 8 out of 9 changed files in this pull request and generated 4 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

You can also share your feedback on Copilot code review. Take the survey.

src/NimBLEStream.cpp

Copilot

Pull request overview

Copilot reviewed 8 out of 9 changed files in this pull request and generated 2 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

You can also share your feedback on Copilot code review. Take the survey.

src/NimBLEStream.cpp

coderabbitai · 2026-03-14T17:55:41Z

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 4817c0d0-239c-433d-80a3-8591db8899a3

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

🔍 Trigger review

✨ Finishing Touches

🧪 Generate unit tests (beta)

Create PR with unit tests
Post copyable unit tests in a comment
Commit unit tests in branch nrf-stream

📝 Coding Plan

Generate coding plan for human review comments

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

Copilot

Pull request overview

Copilot reviewed 8 out of 9 changed files in this pull request and generated 1 comment.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

You can also share your feedback on Copilot code review. Take the survey.

src/NimBLEStream.cpp

Copilot

Pull request overview

Copilot reviewed 8 out of 9 changed files in this pull request and generated 3 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

You can also share your feedback on Copilot code review. Take the survey.

examples/NimBLE_Stream_Server/NimBLE_Stream_Server.ino

examples/NimBLE_Stream_Echo/NimBLE_Stream_Echo.ino

src/NimBLEStream.cpp

Copilot

Pull request overview

Copilot reviewed 10 out of 11 changed files in this pull request and generated 6 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

You can also share your feedback on Copilot code review. Take the survey.

src/NimBLEStream.cpp

src/NimBLEStream.h

Copilot

Pull request overview

Copilot reviewed 10 out of 11 changed files in this pull request and generated 3 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

You can also share your feedback on Copilot code review. Take the survey.

src/NimBLEStream.cpp

Copilot

Pull request overview

Copilot reviewed 10 out of 11 changed files in this pull request and generated 3 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

You can also share your feedback on Copilot code review. Take the survey.

src/NimBLEStream.cpp

src/NimBLEStream.h

h2zero force-pushed the nrf-stream branch from f56b0ff to 84dec8c Compare March 12, 2026 20:28

h2zero requested a review from Copilot March 12, 2026 20:28

Copilot started reviewing on behalf of h2zero March 12, 2026 20:29 View session

Copilot AI reviewed Mar 12, 2026

View reviewed changes

h2zero force-pushed the nrf-stream branch 3 times, most recently from 0f36ca1 to 75d3f9c Compare March 13, 2026 00:30

h2zero requested a review from Copilot March 13, 2026 00:31

Copilot started reviewing on behalf of h2zero March 13, 2026 00:32 View session

Copilot AI reviewed Mar 13, 2026

View reviewed changes

h2zero force-pushed the nrf-stream branch from 75d3f9c to 51542a1 Compare March 13, 2026 00:53

h2zero requested a review from Copilot March 13, 2026 00:54

Copilot started reviewing on behalf of h2zero March 13, 2026 00:55 View session

Copilot AI reviewed Mar 13, 2026

View reviewed changes

src/NimBLEStream.cpp Outdated Show resolved Hide resolved

src/NimBLEStream.cpp Outdated Show resolved Hide resolved

src/NimBLEStream.cpp Outdated Show resolved Hide resolved

src/NimBLEStream.h Outdated Show resolved Hide resolved

src/NimBLEStream.h Outdated Show resolved Hide resolved

h2zero force-pushed the nrf-stream branch from 51542a1 to ffcdf13 Compare March 13, 2026 01:17

h2zero requested a review from Copilot March 13, 2026 01:19

Copilot started reviewing on behalf of h2zero March 13, 2026 01:20 View session

Copilot AI reviewed Mar 13, 2026

View reviewed changes

src/NimBLEStream.cpp Show resolved Hide resolved

src/NimBLEStream.h Show resolved Hide resolved

src/NimBLEStream.cpp Outdated Show resolved Hide resolved

src/NimBLEStream.cpp Outdated Show resolved Hide resolved

h2zero force-pushed the nrf-stream branch 2 times, most recently from 08455f8 to 41baead Compare March 13, 2026 15:50

h2zero requested a review from Copilot March 13, 2026 15:54

Copilot started reviewing on behalf of h2zero March 13, 2026 15:55 View session

Copilot AI reviewed Mar 13, 2026

View reviewed changes

src/NimBLEStream.h Outdated Show resolved Hide resolved

src/NimBLEStream.cpp Outdated Show resolved Hide resolved

src/NimBLEStream.cpp Outdated Show resolved Hide resolved

src/NimBLEStream.cpp Outdated Show resolved Hide resolved

h2zero force-pushed the nrf-stream branch 3 times, most recently from ebf60dd to a17f7e5 Compare March 13, 2026 16:31

h2zero requested a review from Copilot March 13, 2026 16:35

Copilot started reviewing on behalf of h2zero March 13, 2026 16:36 View session

Copilot AI reviewed Mar 13, 2026

View reviewed changes

src/NimBLEStream.cpp Outdated Show resolved Hide resolved

src/NimBLEStream.cpp Show resolved Hide resolved

src/NimBLEStream.cpp Outdated Show resolved Hide resolved

src/NimBLEStream.cpp Outdated Show resolved Hide resolved

h2zero force-pushed the nrf-stream branch from a17f7e5 to 5a22257 Compare March 13, 2026 17:00

Copilot started reviewing on behalf of h2zero March 14, 2026 17:04 View session