add userId header to duplicateSensitivityAnalysisParameters request#962
Merged
khouadrired merged 3 commits intomainfrom Mar 10, 2026
Merged
add userId header to duplicateSensitivityAnalysisParameters request#962khouadrired merged 3 commits intomainfrom
khouadrired merged 3 commits intomainfrom
Conversation
Signed-off-by: Radouane Khouadri <redouane.khouadri_externe@rte-france.com>
Signed-off-by: Radouane Khouadri <redouane.khouadri_externe@rte-france.com>
khouadrired
force-pushed
the
add-userid-header-to-sensi-requests
branch
from
2a7467a to
ec77789
Compare
antoinebhs
reviewed
Mar 9, 2026
| // try to access/duplicate the user profile sensitivity analysis parameters | ||
| try { | ||
| return sensitivityAnalysisService.duplicateSensitivityAnalysisParameters(userProfileInfos.getSensitivityAnalysisParameterId()); | ||
| return sensitivityAnalysisService.duplicateSensitivityAnalysisParameters(userProfileInfos.getSensitivityAnalysisParameterId(), userId); |
Contributor
There was a problem hiding this comment.
remove on create?
https://github.com/gridsuite/study-server/pull/948/changes
antoinebhs
reviewed
Mar 9, 2026
Contributor
antoinebhs
left a comment
antoinebhs
left a comment
There was a problem hiding this comment.
In my opinion this is the quick fix, we should fix it another way:
in security-analysis/sensi we should not have to pass userId for duplication (it's not logic as we don't really use it).
I will create a separate issue for that
Signed-off-by: Radouane Khouadri <redouane.khouadri_externe@rte-france.com>
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
sensitivity-server required a userID passed in the header for
duplicateParameters, but not forcreateParameters