Skip to content

Add notification on computation result update#961

Merged
Meklo merged 7 commits intomainfrom
marcellinh/add_notification_computation_result_update
Mar 10, 2026
Merged

Add notification on computation result update#961
Meklo merged 7 commits intomainfrom
marcellinh/add_notification_computation_result_update

Conversation

@Meklo
Copy link
Contributor

@Meklo Meklo commented Mar 5, 2026

PR Summary

Copy link
Contributor

@flomillot flomillot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't we have two different notifications one for global filters and one for column filters ?

@Meklo
Copy link
Contributor Author

Meklo commented Mar 9, 2026

Shouldn't we have two different notifications one for global filters and one for column filters ?

I broke it down to two notifications :

    UPDATE_COMPUTATION_GLOBAL_FILTER_TAB = 'computationResultGlobalFilterUpdated',
    UPDATE_COMPUTATION_COLUMN_FILTER_TAB = 'computationResultColumnFilterUpdated',

@Meklo Meklo requested a review from flomillot March 9, 2026 09:58
Copy link
Contributor

@ghazwarhili ghazwarhili left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code => Ok
test => Ok

@sonarqubecloud
Copy link

@Meklo Meklo merged commit dcaf831 into main Mar 10, 2026
3 checks passed
@Meklo Meklo deleted the marcellinh/add_notification_computation_result_update branch March 10, 2026 13:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants