-
Notifications
You must be signed in to change notification settings - Fork 99
chore: require Python ≥ 3.9, protobuf ≥ 4.25.8 #877
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
1e45eb4
e3b50d9
4e73563
735b849
6d057a4
717c652
eb5ebef
807a2fa
03d47bd
9012e92
5ef9f1f
38cdc12
be692f4
397d7e1
32132a1
6e20230
9697839
657dcf5
26b8162
b49e1a8
eb08a55
e6d3c4c
c57a4cf
b5f1126
7294f00
a0a278a
0f0afeb
4339dd3
6d4c2eb
1ec9ad2
ff8b6b5
697680c
681ec47
c47dc40
60e9c90
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
This file was deleted.
This file was deleted.
This file was deleted.
This file was deleted.
This file was deleted.
This file was deleted.
This file was deleted.
This file was deleted.
This file was deleted.
This file was deleted.
| Original file line number | Diff line number | Diff line change | ||
|---|---|---|---|---|
|
|
@@ -27,25 +27,7 @@ | |||
|
|
||||
| from google.api_core import exceptions, general_helpers | ||||
|
|
||||
| PROTOBUF_VERSION = google.protobuf.__version__ | ||||
|
|
||||
| # The grpcio-gcp package only has support for protobuf < 4 | ||||
| if PROTOBUF_VERSION[0:2] == "3.": # pragma: NO COVER | ||||
| try: | ||||
| import grpc_gcp | ||||
|
|
||||
| warnings.warn( | ||||
| """Support for grpcio-gcp is deprecated. This feature will be | ||||
| removed from `google-api-core` after January 1, 2024. If you need to | ||||
| continue to use this feature, please pin to a specific version of | ||||
| `google-api-core`.""", | ||||
| DeprecationWarning, | ||||
| ) | ||||
| HAS_GRPC_GCP = True | ||||
| except ImportError: | ||||
| HAS_GRPC_GCP = False | ||||
| else: | ||||
| HAS_GRPC_GCP = False | ||||
| HAS_GRPC_GCP = False | ||||
|
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Created chaser PR #892 |
||||
|
|
||||
|
|
||||
| # The list of gRPC Callable interfaces that return iterators. | ||||
|
|
@@ -366,8 +348,7 @@ def create_channel( | |||
| result in `ValueError` as this combination is not yet supported. | ||||
|
|
||||
| kwargs: Additional key-word args passed to | ||||
| :func:`grpc_gcp.secure_channel` or :func:`grpc.secure_channel`. | ||||
| Note: `grpc_gcp` is only supported in environments with protobuf < 4.0.0. | ||||
| :func:`grpc.secure_channel`. | ||||
|
|
||||
| Returns: | ||||
| grpc.Channel: The created channel. | ||||
|
|
@@ -393,20 +374,6 @@ def create_channel( | |||
| default_host=default_host, | ||||
| ) | ||||
|
|
||||
| # Note that grpcio-gcp is deprecated | ||||
| if HAS_GRPC_GCP: # pragma: NO COVER | ||||
| if compression is not None and compression != grpc.Compression.NoCompression: | ||||
| warnings.warn( | ||||
| "The `compression` argument is ignored for grpc_gcp.secure_channel creation.", | ||||
| DeprecationWarning, | ||||
| ) | ||||
| if attempt_direct_path: | ||||
| warnings.warn( | ||||
| """The `attempt_direct_path` argument is ignored for grpc_gcp.secure_channel creation.""", | ||||
| DeprecationWarning, | ||||
| ) | ||||
| return grpc_gcp.secure_channel(target, composite_credentials, **kwargs) | ||||
|
|
||||
| if attempt_direct_path: | ||||
| target = _modify_target_for_direct_path(target) | ||||
|
|
||||
|
|
||||
Uh oh!
There was an error while loading. Please reload this page.