test(resource-name): generate code for resource name heuristics demo#4936
Draft
haphungw wants to merge 4 commits intogoogleapis:mainfrom
Draft
test(resource-name): generate code for resource name heuristics demo#4936haphungw wants to merge 4 commits intogoogleapis:mainfrom
haphungw wants to merge 4 commits intogoogleapis:mainfrom
Conversation
haphungw
force-pushed
the
feat-resource-name-demo
branch
2 times, most recently
from
83e90de to
3e0de4a
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4936 +/- ##
==========================================
- Coverage 92.81% 92.79% -0.02%
==========================================
Files 225 225
Lines 8665 8665
==========================================
- Hits 8042 8041 -1
- Misses 623 624 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
westarle
reviewed
Mar 8, 2026
haphungw
force-pushed
the
feat-resource-name-demo
branch
9 times, most recently
from
ef1a24b to
24e9f24
Compare
westarle
reviewed
Mar 10, 2026
westarle
reviewed
Mar 10, 2026
haphungw
force-pushed
the
feat-resource-name-demo
branch
3 times, most recently
from
934bcdf to
a84ad39
Compare
westarle
reviewed
Mar 12, 2026
Contributor
westarle
left a comment
westarle
left a comment
There was a problem hiding this comment.
would be nice to see heuristic working for dns!
haphungw
force-pushed
the
feat-resource-name-demo
branch
from
74d6095 to
8d03488
Compare
Contributor
oh and please enable detailedtracingattributes for |
haphungw
force-pushed
the
feat-resource-name-demo
branch
4 times, most recently
from
a5e319e to
f6d61ff
Compare
Contributor
Author
|
googleapis/librarian#4560: final PR to generate the output @ 34fb533 |
haphungw
force-pushed
the
feat-resource-name-demo
branch
from
9e61989 to
1f6f43b
Compare
haphungw
force-pushed
the
feat-resource-name-demo
branch
from
1f6f43b to
378692f
Compare
haphungw
force-pushed
the
feat-resource-name-demo
branch
from
378692f to
e658bfa
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Regenerate all client libraries via
librarian generate --all.We've enabled generating
resource_namevia theresource_name: truetoggle inlibrarian.yamlfor APIs that were previously missing resource names or generating incorrect strings.google-cloud-dns-v1google-cloud-build-v1google-cloud-secret-manager-v1google-cloud-api-keys-v2showcase-v1beta1Depends on:
eligibleServicesallowlist librarian#4469